public inbox for linux-nvme@lists.infradead.org
 help / color / mirror / Atom feed
From: Alan Adamson <alan.adamson@oracle.com>
To: Chaitanya Kulkarni <chaitanyak@nvidia.com>
Cc: Keith Busch <kbusch@meta.com>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	"hch@lst.de" <hch@lst.de>, "sagi@grimberg.me" <sagi@grimberg.me>,
	Keith Busch <kbusch@kernel.org>, Daniel Wagner <dwagner@suse.de>
Subject: Re: [PATCH] nvme: quiet user passthrough command errors
Date: Wed, 26 Oct 2022 18:08:34 +0000	[thread overview]
Message-ID: <D94917CF-9369-41C6-8F83-FFC36BEAF8BF@oracle.com> (raw)
In-Reply-To: <52e66f7f-30a8-0726-3db5-dee2b010c1a2@nvidia.com>



> On Oct 26, 2022, at 11:04 AM, Chaitanya Kulkarni <chaitanyak@nvidia.com> wrote:
> 
> On 10/26/2022 10:07 AM, Keith Busch wrote:
>> From: Keith Busch <kbusch@kernel.org>
>> 
>> The driver is spamming the kernel logs for entirely harmless errors from
>> user space submitting unsupported commmands. Just silence the errors.
>> The application has direct access to command status, so there's no need
>> to log these.
>> 
>> Cc: Daniel Wagner <dwagner@suse.de>
>> Cc: Alan Adamson <alan.adamson@oracle.com>
>> Signed-off-by: Keith Busch <kbusch@kernel.org>
>> ---
> 
> 
> This should do the trick, however it will be great if reporter
> can provide tested-by.
> 
> Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
> 
> -ck
> 
> 


I’ll be testing it today.

Alan

  reply	other threads:[~2022-10-26 18:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20221026171201epcas5p1f6333717c7f12b5a8fe362cf09c5447d@epcas5p1.samsung.com>
2022-10-26 17:07 ` [PATCH] nvme: quiet user passthrough command errors Keith Busch
2022-10-26 18:04   ` Chaitanya Kulkarni
2022-10-26 18:08     ` Alan Adamson [this message]
2022-10-26 18:19     ` Keith Busch
2022-10-26 21:27   ` Alan Adamson
2022-10-27  5:41   ` Kanchan Joshi
2022-10-27 13:17     ` Jens Axboe
2022-10-27 15:00       ` Keith Busch
2022-10-27 16:40         ` Chaitanya Kulkarni
2022-10-27 13:14   ` Pankaj Raghav

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D94917CF-9369-41C6-8F83-FFC36BEAF8BF@oracle.com \
    --to=alan.adamson@oracle.com \
    --cc=chaitanyak@nvidia.com \
    --cc=dwagner@suse.de \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=kbusch@meta.com \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox