From: "Maurizio Lombardi" <mlombard@bsdbackstore.eu>
To: "Sagi Grimberg" <sagi@grimberg.me>,
"Maurizio Lombardi" <mlombard@redhat.com>, <kbusch@meta.com>
Cc: <hare@kernel.org>, <linux-nvme@lists.infradead.org>,
<zhang.guanghui@cestc.cn>, <loberman@redhat.com>
Subject: Re: [PATCH V4 1/2] nvme-tcp: Prevent infinite loop if socket closes during CONNECTING state
Date: Thu, 17 Apr 2025 15:04:14 +0200 [thread overview]
Message-ID: <D98XO9X62V98.1OGPR20IUZ9EO@bsdbackstore.eu> (raw)
In-Reply-To: <fc197a49-32f9-44ff-be3c-4efa1d42d0b0@grimberg.me>
On Mon Apr 14, 2025 at 11:35 PM CEST, Sagi Grimberg wrote:
>
> I see the issue, but we need to make sure that if the connection closes
> before
> the controller finished establishing, then it cleans up correctly.
> Because at some
> point in the past - it wasn't the case. Things have changed in that path
> so it might
> be ok now... Just need to check. I'd trigger the race while the admin
> queue is establishing, as well
> as in the middle of the sequence of IO queues are establishing.
I believe my earlier testing for this patch already covered this scenario,
but I can rerun the tests to confirm and report back.
Either way, any fixes needed should be unrelated to this patch in my opinion,
as this one covers the case where the controller
has already finished establishing the admin and I/O queues.
Maurizio
next prev parent reply other threads:[~2025-04-17 14:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-04 8:27 [PATCH V4 0/2] Fix race conditions in the nvme-tcp driver Maurizio Lombardi
2025-04-04 8:28 ` [PATCH V4 1/2] nvme-tcp: Prevent infinite loop if socket closes during CONNECTING state Maurizio Lombardi
2025-04-05 23:22 ` Keith Busch
2025-04-07 6:11 ` Hannes Reinecke
2025-04-13 22:44 ` Sagi Grimberg
2025-04-14 7:25 ` Maurizio Lombardi
2025-04-14 21:35 ` Sagi Grimberg
2025-04-17 13:04 ` Maurizio Lombardi [this message]
2025-04-18 11:14 ` Sagi Grimberg
2025-06-10 12:50 ` Maurizio Lombardi
2025-06-10 14:29 ` Sagi Grimberg
[not found] ` <202510211137214079503@cestc.cn>
2025-10-21 6:05 ` [PATCH V4 1/2] nvme-tcp: Prevent infinite loop if socket closes during CONNECTING state【请注意，邮件由sagigrim@gmail.com代发】 Maurizio Lombardi
2025-10-21 6:14 ` Maurizio Lombardi
2025-04-04 8:28 ` [PATCH V4 2/2] nvme-tcp: do not complete the request if send operation fails Maurizio Lombardi
2025-04-05 23:23 ` Keith Busch
2025-04-07 6:13 ` Hannes Reinecke
2025-04-11 12:26 ` [PATCH V4 0/2] Fix race conditions in the nvme-tcp driver Maurizio Lombardi
2025-04-13 22:42 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D98XO9X62V98.1OGPR20IUZ9EO@bsdbackstore.eu \
--to=mlombard@bsdbackstore.eu \
--cc=hare@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-nvme@lists.infradead.org \
--cc=loberman@redhat.com \
--cc=mlombard@redhat.com \
--cc=sagi@grimberg.me \
--cc=zhang.guanghui@cestc.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).