Re: [PATCH V4 1/2] nvme-tcp: Prevent infinite loop if socket closes\r during CONNECTING state【请注意，邮件由sagigrim@gmail.com代发】

["Maurizio Lombardi" <mlombard@bsdbackstore.eu>]

On Tue Oct 21, 2025 at 5:37 AM CEST, zhang.guanghui@cestc.cn wrote:
> This patch has not been merged yet,
> So far, no other issues were found after merging this patch.

Wait, do not merge it.

nvme_tcp_error_recovery() should only be called when an -ENOPIPE error
is detected. Other errors may be temporary, like -ENOPERM, and we
shouldn't reset the connection in that case.

Merging this patch as-is will make the blktests md/001 fail.

Let me re-post a new version.

Maurizio

>  
>
> zhang.guanghui@cestc.cn
>  
> 发件人： Sagi Grimberg
> 发送时间： 2025-06-10 22:29
> 收件人： Maurizio Lombardi; Maurizio Lombardi; kbusch
> 抄送： hare; linux-nvme; zhang.guanghui; loberman
> 主题： Re: [PATCH V4 1/2] nvme-tcp: Prevent infinite loop if socket closes during CONNECTING state【请注意，邮件由sagigrim@gmail.com代发】
>  
>  
> On 10/06/2025 15:50, Maurizio Lombardi wrote:
>> On Fri Apr 18, 2025 at 1:14 PM CEST, Sagi Grimberg wrote:
>>>
>>> On 4/17/25 16:04, Maurizio Lombardi wrote:
>>>> On Mon Apr 14, 2025 at 11:35 PM CEST, Sagi Grimberg wrote:
>>>>> I see the issue, but we need to make sure that if the connection closes
>>>>> before
>>>>> the controller finished establishing, then it cleans up correctly.
>>>>> Because at some
>>>>> point in the past - it wasn't the case. Things have changed in that path
>>>>> so it might
>>>>> be ok now... Just need to check. I'd trigger the race while the admin
>>>>> queue is establishing, as well
>>>>> as in the middle of the sequence of IO queues are establishing.
>>>> I believe my earlier testing for this patch already covered this scenario,
>>>> but I can rerun the tests to confirm and report back.
>>> So you indeed made sure that the failure starts sporadically in the
>>> controller establishment sequence
>>> and there is no use-after-free issue?
>> Sorry for the long wait; I am now back at it.
>> I repeated the tests using a debug kernel, and nothing has been detected.
>  
> OK, then lets get it merged.
>  
> Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
>  
>