From: "Maurizio Lombardi" <mlombard@bsdbackstore.eu>
To: "Maurizio Lombardi" <mlombard@bsdbackstore.eu>,
"zhang.guanghui@cestc.cn" <zhang.guanghui@cestc.cn>,
"sagi" <sagi@grimberg.me>,
"Maurizio Lombardi" <mlombard@redhat.com>,
"kbusch" <kbusch@meta.com>
Cc: "hare" <hare@kernel.org>,
"linux-nvme" <linux-nvme@lists.infradead.org>,
"loberman" <loberman@redhat.com>
Subject: Re: [PATCH V4 1/2] nvme-tcp: Prevent infinite loop if socket closes\r during CONNECTING state【请注意，邮件由sagigrim@gmail.com代发】
Date: Tue, 21 Oct 2025 08:14:53 +0200 [thread overview]
Message-ID: <DDNS2QC0RU49.ZBFYG5AGV3FE@bsdbackstore.eu> (raw)
In-Reply-To: <DDNRV5MAVQCF.2SH49C0P5MKVF@bsdbackstore.eu>
On Tue Oct 21, 2025 at 8:05 AM CEST, Maurizio Lombardi wrote:
> On Tue Oct 21, 2025 at 5:37 AM CEST, zhang.guanghui@cestc.cn wrote:
>> This patch has not been merged yet,
>> So far, no other issues were found after merging this patch.
>
> Wait, do not merge it.
>
> nvme_tcp_error_recovery() should only be called when an -ENOPIPE error
> is detected. Other errors may be temporary, like -ENOPERM, and we
> shouldn't reset the connection in that case.
>
> Merging this patch as-is will make the blktests md/001 fail.
>
> Let me re-post a new version.
Also, as Sagi pointed out, during the initial connect there is no
expectation of error recovery, so there is more work to do.
Going to see if I can come up with something more robust.
Maurizio
next prev parent reply other threads:[~2025-10-21 6:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-04 8:27 [PATCH V4 0/2] Fix race conditions in the nvme-tcp driver Maurizio Lombardi
2025-04-04 8:28 ` [PATCH V4 1/2] nvme-tcp: Prevent infinite loop if socket closes during CONNECTING state Maurizio Lombardi
2025-04-05 23:22 ` Keith Busch
2025-04-07 6:11 ` Hannes Reinecke
2025-04-13 22:44 ` Sagi Grimberg
2025-04-14 7:25 ` Maurizio Lombardi
2025-04-14 21:35 ` Sagi Grimberg
2025-04-17 13:04 ` Maurizio Lombardi
2025-04-18 11:14 ` Sagi Grimberg
2025-06-10 12:50 ` Maurizio Lombardi
2025-06-10 14:29 ` Sagi Grimberg
[not found] ` <202510211137214079503@cestc.cn>
2025-10-21 6:05 ` [PATCH V4 1/2] nvme-tcp: Prevent infinite loop if socket closes during CONNECTING state【请注意，邮件由sagigrim@gmail.com代发】 Maurizio Lombardi
2025-10-21 6:14 ` Maurizio Lombardi [this message]
2025-04-04 8:28 ` [PATCH V4 2/2] nvme-tcp: do not complete the request if send operation fails Maurizio Lombardi
2025-04-05 23:23 ` Keith Busch
2025-04-07 6:13 ` Hannes Reinecke
2025-04-11 12:26 ` [PATCH V4 0/2] Fix race conditions in the nvme-tcp driver Maurizio Lombardi
2025-04-13 22:42 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DDNS2QC0RU49.ZBFYG5AGV3FE@bsdbackstore.eu \
--to=mlombard@bsdbackstore.eu \
--cc=hare@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-nvme@lists.infradead.org \
--cc=loberman@redhat.com \
--cc=mlombard@redhat.com \
--cc=sagi@grimberg.me \
--cc=zhang.guanghui@cestc.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).