From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1D2F8CCF9F8 for ; Thu, 30 Oct 2025 06:55:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:From: Subject:Cc:To:Message-Id:Date:Content-Type:Content-Transfer-Encoding: Mime-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gWdOIKYzEV2Weyw6pVye8lQucb9XPd2I6i64b+qWt4A=; b=asEob0yMxBBV7MskNIkbksOKTI sKWJsGJ7ciMupfyPchv5dgJDRMZeSClrgGMv26LP8jrdorLJseE3dLRAxaW2PDzWRKtNVulx1lhMR lRrhIwmCNS/k8b+Ky8LdXxMH8xkkshvfrNqYCBDKIvSA14zGJdca0+vcSO6U3H3fGAljxMAzKpiNA DNKw9RHDxPA0kO7jIf9XNWU4diU8I5Q0kyglOXsc586kMKeDmEk+X0TdCisU32vlOKPowZcSRhQKd 1zSjnk7TrwkR0EcgANJJRaIudF37SybD+T8z/01hJ1zZKJdsdzkED9/rn7xIrDa9YUqB/4DT1tvhu QMP6AkxA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vEMYv-00000003axS-2kpM; Thu, 30 Oct 2025 06:55:09 +0000 Received: from 128-116-240-228.dyn.eolo.it ([128.116.240.228] helo=bsdbackstore.eu) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vEMYr-00000003ax1-0imq for linux-nvme@lists.infradead.org; Thu, 30 Oct 2025 06:55:07 +0000 Received: from localhost ( [192.168.3.39]) by bsdbackstore.eu (OpenSMTPD) with ESMTPSA id 540c91f6 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Thu, 30 Oct 2025 07:55:03 +0100 (CET) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 30 Oct 2025 07:55:02 +0100 Message-Id: To: "Chaitanya Kulkarni" , "Maurizio Lombardi" Cc: "bgurney@redhat.com" , "linux-nvme@lists.infradead.org" , "kbusch@kernel.org" , "Bart Van Assche" Subject: Re: [PATCH] nvme-pci: expose active quirks in sysfs From: "Maurizio Lombardi" X-Mailer: aerc References: <20251028142916.700438-1-mlombard@redhat.com> <2bfd5388-0bde-4f86-9edf-fb74dd0d4c79@acm.org> <08f479ed-9817-4806-bf68-c929c8a844a6@nvidia.com> <5f38e8ae-41c3-46ef-ac3d-b6e1c106379f@nvidia.com> In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251029_235506_693750_F8A46363 X-CRM114-Status: GOOD ( 13.49 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Thu Oct 30, 2025 at 7:46 AM CET, Chaitanya Kulkarni wrote: > On 10/29/25 23:18, Maurizio Lombardi wrote: > > how about something like this totally untested ? > > drivers/nvme/host/pci.c | 64 +++++++++++++++++++++++++++++++++++++++++ > =C2=A01 file changed, 64 insertions(+) > > diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c > index c916176bd9f0..ea9904e2dbd9 100644 > --- a/drivers/nvme/host/pci.c > +++ b/drivers/nvme/host/pci.c > @@ -2497,6 +2497,69 @@ static ssize_t cmbsz_show(struct device *dev,=20 > struct device_attribute *attr, > =C2=A0} > =C2=A0static DEVICE_ATTR_RO(cmbsz); > > +static const struct { > +=C2=A0 =C2=A0 unsigned long quirk; > +=C2=A0 =C2=A0 const char *name; > +} nvme_quirk_info[] =3D { > +=C2=A0 =C2=A0 { NVME_QUIRK_STRIPE_SIZE,=C2=A0 =C2=A0 =C2=A0 =C2=A0 "STRI= PE_SIZE" }, > +=C2=A0 =C2=A0 { NVME_QUIRK_IDENTIFY_CNS,=C2=A0 =C2=A0 =C2=A0 =C2=A0 "IDE= NTIFY_CNS" }, > +=C2=A0 =C2=A0 { NVME_QUIRK_DEALLOCATE_ZEROES,=C2=A0 =C2=A0 =C2=A0 =C2=A0= "DEALLOCATE_ZEROES" }, > +=C2=A0 =C2=A0 { NVME_QUIRK_DELAY_BEFORE_CHK_RDY, "DELAY_BEFORE_CHK_RDY" = }, > +=C2=A0 =C2=A0 { NVME_QUIRK_NO_APST,=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 "NO_APST" }, > +=C2=A0 =C2=A0 { NVME_QUIRK_NO_DEEPEST_PS,=C2=A0 =C2=A0 =C2=A0 =C2=A0 "NO= _DEEPEST_PS" }, > +=C2=A0 =C2=A0 { NVME_QUIRK_QDEPTH_ONE,=C2=A0 =C2=A0 =C2=A0 =C2=A0 "QDEPT= H_ONE" }, > +=C2=A0 =C2=A0 { NVME_QUIRK_MEDIUM_PRIO_SQ,=C2=A0 =C2=A0 =C2=A0 =C2=A0 "M= EDIUM_PRIO_SQ" }, > +=C2=A0 =C2=A0 { NVME_QUIRK_IGNORE_DEV_SUBNQN,=C2=A0 =C2=A0 =C2=A0 =C2=A0= "IGNORE_DEV_SUBNQN" }, > +=C2=A0 =C2=A0 { NVME_QUIRK_DISABLE_WRITE_ZEROES, "DISABLE_WRITE_ZEROES" = }, > +=C2=A0 =C2=A0 { NVME_QUIRK_SIMPLE_SUSPEND,=C2=A0 =C2=A0 =C2=A0 =C2=A0 "S= IMPLE_SUSPEND" }, > +=C2=A0 =C2=A0 { NVME_QUIRK_SINGLE_VECTOR,=C2=A0 =C2=A0 =C2=A0 =C2=A0 "SI= NGLE_VECTOR" }, > +=C2=A0 =C2=A0 { NVME_QUIRK_128_BYTES_SQES,=C2=A0 =C2=A0 =C2=A0 =C2=A0 "1= 28_BYTES_SQES" }, > +=C2=A0 =C2=A0 { NVME_QUIRK_SHARED_TAGS,=C2=A0 =C2=A0 =C2=A0 =C2=A0 "SHAR= ED_TAGS" }, > +=C2=A0 =C2=A0 { NVME_QUIRK_NO_TEMP_THRESH_CHANGE, "NO_TEMP_THRESH_CHANGE= " }, > +=C2=A0 =C2=A0 { NVME_QUIRK_NO_NS_DESC_LIST,=C2=A0 =C2=A0 =C2=A0 =C2=A0 "= NO_NS_DESC_LIST" }, > +=C2=A0 =C2=A0 { NVME_QUIRK_DMA_ADDRESS_BITS_48,=C2=A0 =C2=A0 "DMA_ADDRES= S_BITS_48" }, > +=C2=A0 =C2=A0 { NVME_QUIRK_SKIP_CID_GEN,=C2=A0 =C2=A0 =C2=A0 =C2=A0 "SKI= P_CID_GEN" }, > +=C2=A0 =C2=A0 { NVME_QUIRK_BOGUS_NID,=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 "BOGUS_NID" }, > +=C2=A0 =C2=A0 { NVME_QUIRK_NO_SECONDARY_TEMP_THRESH, "NO_SECONDARY_TEMP_= THRESH" }, > +=C2=A0 =C2=A0 { NVME_QUIRK_FORCE_NO_SIMPLE_SUSPEND, "FORCE_NO_SIMPLE_SUS= PEND" }, > +=C2=A0 =C2=A0 { NVME_QUIRK_BROKEN_MSI,=C2=A0 =C2=A0 =C2=A0 =C2=A0 "BROKE= N_MSI" }, > +=C2=A0 =C2=A0 { NVME_QUIRK_DMAPOOL_ALIGN_512,=C2=A0 =C2=A0 =C2=A0 =C2=A0= "DMAPOOL_ALIGN_512" }, > +}; Hmm, NVME_QUIRK_DMAPOOL_ALIGN_512 is "1 << 22", wouldn't this create=20 an enormous array? Maurizio > + > +static int nvme_get_quirks_string(unsigned long quirks, char *buf,=20 > size_t buf_len) > +{ > +=C2=A0 =C2=A0 size_t len =3D 0; > +=C2=A0 =C2=A0 int i; > + > +=C2=A0 =C2=A0 if (!quirks) { > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 len =3D scnprintf(buf, buf_len, "No quirks e= nabled\n"); > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 return len; > +=C2=A0 =C2=A0 } > + > +=C2=A0 =C2=A0 len +=3D scnprintf(buf + len, buf_len - len, "Active quirk= s:\n"); > + > +=C2=A0 =C2=A0 for (i =3D 0; i < ARRAY_SIZE(nvme_quirk_info); i++) { > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 if (quirks & nvme_quirk_info[i].quirk) > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 len +=3D scnprintf(buf + len, = buf_len - len, " %s\n", > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0nvme_quirk_info[i].name); > +=C2=A0 =C2=A0 } > + > +=C2=A0 =C2=A0 return len; > +} > + > +static ssize_t quirks_show(struct device *dev, struct device_attribute= =20 > *attr, > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0char *buf) > +{ > +=C2=A0 =C2=A0 struct nvme_dev *ndev =3D to_nvme_dev(dev_get_drvdata(dev)= ); > +=C2=A0 =C2=A0 int len; > + > +=C2=A0 =C2=A0 len =3D sysfs_emit(buf, "0x%016lx\n\n", ndev->ctrl.quirks)= ; > +=C2=A0 =C2=A0 len +=3D nvme_get_quirks_string(ndev->ctrl.quirks, buf + l= en,=20 > PAGE_SIZE - len); > + > +=C2=A0 =C2=A0 return len; > +} > +static DEVICE_ATTR_RO(quirks); > + > =C2=A0static ssize_t hmb_show(struct device *dev, struct device_attribut= e *attr, > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0char *buf) > =C2=A0{ > @@ -2557,6 +2620,7 @@ static struct attribute *nvme_pci_attrs[] =3D { > =C2=A0 =C2=A0 =C2=A0&dev_attr_cmbloc.attr, > =C2=A0 =C2=A0 =C2=A0&dev_attr_cmbsz.attr, > =C2=A0 =C2=A0 =C2=A0&dev_attr_hmb.attr, > +=C2=A0 =C2=A0 &dev_attr_quirks.attr, > =C2=A0 =C2=A0 =C2=A0NULL, > =C2=A0};