From: Potnuri Bharat Teja <bharat@chelsio.com>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Samuel Jones <sjones@kalrayinc.com>, "hch@lst.de" <hch@lst.de>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: Re: Request timeout seen with NVMEoF TCP
Date: Mon, 21 Dec 2020 13:20:53 +0530 [thread overview]
Message-ID: <X+BT3VpGDywEb1wX@chelsio.com> (raw)
In-Reply-To: <52bc9a04-777d-7a29-d784-468a69aa1478@grimberg.me>
On Friday, December 12/18/20, 2020 at 17:35:01 -0800, Sagi Grimberg wrote:
>
> > > Potnuri, does this patch solves what you are seeing?
> >
> > Hi Sagi,
> > Below patch works fine. I have it running all night with out any issues.
> > Thanks.
>
> Thanks Potnuri, can you try the patch without the nvme_tcp_io_work
> portion? I think the issue can be resolved with just adding
> nvme_tcp_send_all..
>
Yes. Issue is resolved with just nvme_tcp_send_all() change:
Test runs fine for me.
Thanks.
> Thinking more about what Mark mentioned and it is correct
> that io_work needs to reschedule itself if it wasn't able
> to acquire the send_mutex hence I am not sure it is needed.
>
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
prev parent reply other threads:[~2020-12-21 7:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 17:19 Request timeout seen with NVMEoF TCP Potnuri Bharat Teja
2020-12-09 18:02 ` Sagi Grimberg
2020-12-10 17:06 ` Potnuri Bharat Teja
2020-12-10 21:47 ` Sagi Grimberg
2020-12-11 7:26 ` Potnuri Bharat Teja
2020-12-14 17:51 ` Sagi Grimberg
2020-12-14 18:05 ` Potnuri Bharat Teja
2020-12-14 19:27 ` Samuel Jones
2020-12-14 20:13 ` Sagi Grimberg
2020-12-15 1:53 ` Sagi Grimberg
2020-12-15 18:30 ` Wunderlich, Mark
2020-12-19 1:04 ` Sagi Grimberg
2020-12-16 5:51 ` Potnuri Bharat Teja
2020-12-19 1:35 ` Sagi Grimberg
2020-12-21 7:50 ` Potnuri Bharat Teja [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X+BT3VpGDywEb1wX@chelsio.com \
--to=bharat@chelsio.com \
--cc=hch@lst.de \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=sjones@kalrayinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).