From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7323FC433FE for ; Sat, 15 Oct 2022 05:51:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kPntWr7A6bA616PExnbnx5reDbccdV4V+F7u1oTVbdw=; b=Wh8EsT6DE4JAiBEcrBQupfiU9v HpLHbCdBDcPc2zzSnIaVvjx/iU3A6t5litRsCG1QbIDAeXBKBAc7agQJ+i6yGMjmx6ydfN5TWCqkU 3A/KXM+HhMyBinsxg5veUN0+n/HT/GxvjWHTLRSBkHZvsYOSItIu3BGhBBqsCp7Zxg/oKvQ6MJQAn 1Yu1ny7AvCwumbpTx96SIdvQ3ljs/WO4zA9j1xKHGVvF1Keloys73iFnOZaksssgFoldPNcCHQopF YcrZ4KGqFqQxEv43TIOl9F40rZlLDi2w7aKAktdV22hKbWlxIQfu5iPwIkcmlC1PsBx+rzcWecSmt 3txBH9Rg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oja57-00GVAM-0F; Sat, 15 Oct 2022 05:51:33 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oj0xi-00CPj5-89; Thu, 13 Oct 2022 16:21:35 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A34AAB81F3E; Thu, 13 Oct 2022 16:21:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C5671C433D6; Thu, 13 Oct 2022 16:21:28 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="GP4P33Go" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1665678086; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kPntWr7A6bA616PExnbnx5reDbccdV4V+F7u1oTVbdw=; b=GP4P33GoTZTXwgHWO1z/FqyjryY8qsqfXNBCumID69G06rmzAbuflrmGXm0knLxOwy6AOV r5Se8is8rcJ8teWZq2zoRDvfJGTZawQk7FulxMoGHupIBrT9us1rnRt6jRmg3GIbXoJ/w6 20UjSRmQn/6S5nyrDvb7rvSacSvCVHE= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 5f752f1b (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Thu, 13 Oct 2022 16:21:25 +0000 (UTC) Date: Thu, 13 Oct 2022 10:21:18 -0600 From: "Jason A. Donenfeld" To: Rolf Eike Beer Cc: Florian Westphal , linux-kernel@vger.kernel.org, patches@lists.linux.dev, Andrew Morton , Herbert Xu , Thomas Graf , kasan-dev@googlegroups.com, Greg Kroah-Hartman , kernel-janitors@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-block@vger.kernel.org, linux-crypto@vger.kernel.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-media@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, linux-parisc@vger.kernel.org, linux-rdma@vger.kernel.org, linux-s390@vger.kernel.org, linux-um@lists.infradead.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v6 5/7] treewide: use get_random_u32() when possible Message-ID: References: <20221010230613.1076905-1-Jason@zx2c4.com> <3026360.ZldQQBzMgz@eto.sf-tec.de> <20221013101635.GB11818@breakpoint.cc> <11986571.xaOnivgMc4@eto.sf-tec.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <11986571.xaOnivgMc4@eto.sf-tec.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221013_092134_455333_79A7212E X-CRM114-Status: GOOD ( 15.29 ) X-Mailman-Approved-At: Fri, 14 Oct 2022 22:51:19 -0700 X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Thu, Oct 13, 2022 at 01:40:40PM +0200, Rolf Eike Beer wrote: > Am Donnerstag, 13. Oktober 2022, 12:16:35 CEST schrieb Florian Westphal: > > Rolf Eike Beer wrote: > > > Florian, can you comment and maybe fix it? > > > > Can't comment, do not remember -- this was 5 years ago. > > > > > Or you wanted to move the variable before the loop and keep the random > > > state between the loops and only reseed when all '1' bits have been > > > consumed. > > Probably. No clue, best to NOT change it to not block Jasons series and > > then just simplify this and remove all the useless shifts. > > Sure. Jason, just in case you are going to do a v7 this could move to u8 then. Indeed I think this is one to send individually to netdev@ once the tree opens there for 6.2. Jason