From: Niklas Cassel <Niklas.Cassel@wdc.com>
To: Christoph Hellwig <hch@lst.de>
Cc: "kbusch@kernel.org" <kbusch@kernel.org>,
"sagi@grimberg.me" <sagi@grimberg.me>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH] nvme: implement the DEAC bit for the Write Zeroes command
Date: Wed, 2 Nov 2022 10:46:24 +0000 [thread overview]
Message-ID: <Y2JKQEgtOYk2die6@x1-carbon> (raw)
In-Reply-To: <20221030162906.3390-1-hch@lst.de>
On Sun, Oct 30, 2022 at 05:29:06PM +0100, Christoph Hellwig wrote:
> While the specification allows devices to either deallocate data
> or to actually write zeroes on any Write Zeroes command, many SSDs
> only do the sensible thing and deallocate data when the DEAC bit
> is specific. Set it when it is suppored and the caller doesn't
Nit: supported
> explicitly opt out of deallocation.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
Reviewed-by: Niklas Cassel <niklas.cassel@wdc.com>
next prev parent reply other threads:[~2022-11-02 10:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-30 16:29 [PATCH] nvme: implement the DEAC bit for the Write Zeroes command Christoph Hellwig
2022-10-31 9:01 ` Guixin Liu
2022-10-31 14:43 ` Pankaj Raghav
2022-10-31 14:54 ` Martin K. Petersen
2022-10-31 15:07 ` Keith Busch
2022-10-31 15:48 ` Martin K. Petersen
2022-11-01 9:58 ` Christoph Hellwig
2022-11-01 15:49 ` Martin K. Petersen
2022-11-04 7:06 ` Christoph Hellwig
2022-11-01 9:59 ` Christoph Hellwig
2022-11-02 10:46 ` Niklas Cassel [this message]
2022-11-02 15:56 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2JKQEgtOYk2die6@x1-carbon \
--to=niklas.cassel@wdc.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox