Re: [PATCH 2/6] nvme: add support for the Verify command

Chaitanya Kulkarni
2022-07-06T04:09:59Z

On 7/5/22 01:34, Christoph Hellwig wrote:
> On Thu, Jun 30, 2022 at 10:24:14AM -0600, Keith Busch wrote:
>> On Thu, Jun 30, 2022 at 02:14:02AM -0700, Chaitanya Kulkarni wrote:
>>> Allow verify operations (REQ_OP_VERIFY) on the block device, if the
>>> device supports optional command bit set for verify. Add support
>>> to setup verify command. Set maximum possible verify sectors in one
>>> verify command according to maximum hardware sectors supported by the
>>> controller.
>>
>> Shouldn't the limit be determined by Identify Controller NVM CSS's 'VSL' field
>> instead of its max data transfer?
>
> Yes.

Okay will move to the helper and add limit.

-ck