From: Dan Carpenter <error27@gmail.com>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: linux-nvme@lists.infradead.org, Christoph Hellwig <hch@lst.de>,
Keith Busch <kbusch@kernel.org>, Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH] nvme-auth: fix smatch warning complaints
Date: Tue, 27 Dec 2022 20:53:48 +0300 [thread overview]
Message-ID: <Y6sxLFLVvFmaxGzN@kadam> (raw)
In-Reply-To: <20221225112851.351885-1-sagi@grimberg.me>
On Sun, Dec 25, 2022 at 01:28:51PM +0200, Sagi Grimberg wrote:
> When initializing auth context, there may be no secrets passed
> by the user. Make return code explicit when returning successfully.
>
> smatch warnings:
> drivers/nvme/host/auth.c:950 nvme_auth_init_ctrl() warn: missing error code? 'ret'
>
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <error27@gmail.com>
> Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
Awesome. Thanks!
regards,
dan carpenter
next prev parent reply other threads:[~2022-12-27 17:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-25 11:28 [PATCH] nvme-auth: fix smatch warning complaints Sagi Grimberg
2022-12-27 17:53 ` Dan Carpenter [this message]
2022-12-28 15:37 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y6sxLFLVvFmaxGzN@kadam \
--to=error27@gmail.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox