From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 843AFC32793 for ; Wed, 18 Jan 2023 08:22:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zRwqDvtswpcNxL27g78WUlL6FGqpbvPDdxVCL1gDPRg=; b=UvxPU8/c4R3lZtPxd6Lwoq0MIP NSvL0CiWyAncqQHo7UwkTs3wLog5Z2qTmlV1DFFnJCA04hJvoqvc5lCmhsNuD6kgf3dOpHZ1XT90+ LingqKLYwgS5oaibqASb7Or+XmNJnGUyapuatBDXsEeqKP2/nSLAUn2SYsb2wcjPsqKLwh/lR2FfJ S7IlEGW98uFQyePkeYfbs27wVQLdtnQOC66ScPCf6UYxbPn6WlLiMeZhTrmekKmAQrcbnp+lcpe0m dSUUjiDXA3jzXlYUMKt/e41bQ+ficsCzcMPHHT8NQsf9o7HApagAzqo9rSfhtvmBCOE3mHz3wSfAd ekzzvmPg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pI3iR-00HRve-JN; Wed, 18 Jan 2023 08:22:39 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pI3iP-00HRun-1N for linux-nvme@lists.infradead.org; Wed, 18 Jan 2023 08:22:38 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6611B616F7; Wed, 18 Jan 2023 08:22:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0C176C433EF; Wed, 18 Jan 2023 08:22:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674030155; bh=J3P2jLNBlTxVtW6CzAaV5JkcOWy8oIduGW1AIFf0FvM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RrmsUcrdRqqVIlnk7HhrT7HkNkthDZLdAmJAbvi5YDXIY/MF7FZv7NLBXeF4D5emv 5L2jF3QW8mYDpL17de3mblOvmVPuLZWT1KBQnnv6nLLYB7DdBp4hkmmA3n7yCBr8Et 2abB0rQoHKGYzfmSFbLBBVVVZ4W68YsQ5XUcPY1n9Zv26lgCb7KN3n3SsJB6cI9q8v TXOSpovnW+MSNrF/HvLcd7jYv4u/vgbv9yuRPaOm7JQ8kQt5JVGfg464elsybVphlM GJILETQ0yFevJ5Bb7NB0QBJ5g6k0Qy0BpmbwvOwlvxvlybJIQdIILu94VA0iNGYJLN zZfXJgAM2Cg6Q== Date: Wed, 18 Jan 2023 10:22:31 +0200 From: Leon Romanovsky To: Eric Biggers Cc: Jason Gunthorpe , Bryan Tan , Christoph Hellwig , Eric Dumazet , Israel Rukshin , Jakub Kicinski , Jens Axboe , Keith Busch , linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Masami Hiramatsu , Max Gurtovoy , netdev@vger.kernel.org, Paolo Abeni , Saeed Mahameed , Sagi Grimberg , Selvin Xavier , Steven Rostedt , Vishnu Dasa , Yishai Hadas Subject: Re: [PATCH rdma-next 00/13] Add RDMA inline crypto support Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230118_002237_181343_CCB7CC76 X-CRM114-Status: GOOD ( 26.21 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Tue, Jan 17, 2023 at 10:47:44PM -0800, Eric Biggers wrote: > Hi Leon, > > On Mon, Jan 16, 2023 at 03:05:47PM +0200, Leon Romanovsky wrote: > > >From Israel, > > > > The purpose of this patchset is to add support for inline > > encryption/decryption of the data at storage protocols like nvmf over > > RDMA (at a similar way like integrity is used via unique mkey). > > > > This patchset adds support for plaintext keys. The patches were tested > > on BF-3 HW with fscrypt tool to test this feature, which showed reduce > > in CPU utilization when comparing at 64k or more IO size. The CPU utilization > > was improved by more than 50% comparing to the SW only solution at this case. > > > > How to configure fscrypt to enable plaintext keys: > > # mkfs.ext4 -O encrypt /dev/nvme0n1 > > # mount /dev/nvme0n1 /mnt/crypto -o inlinecrypt > > # head -c 64 /dev/urandom > /tmp/master_key > > # fscryptctl add_key /mnt/crypto/ < /tmp/master_key > > # mkdir /mnt/crypto/test1 > > # fscryptctl set_policy 152c41b2ea39fa3d90ea06448456e7fb /mnt/crypto/test1 > > ** “152c41b2ea39fa3d90ea06448456e7fb” is the output of the > > “fscryptctl add_key” command. > > # echo foo > /mnt/crypto/test1/foo > > > > Notes: > > - At plaintext mode only, the user set a master key and the fscrypt > > driver derived from it the DEK and the key identifier. > > - 152c41b2ea39fa3d90ea06448456e7fb is the derived key identifier > > - Only on the first IO, nvme-rdma gets a callback to load the derived DEK. > > > > There is no special configuration to support crypto at nvme modules. > > > > Thanks > > Very interesting work! Can you Cc me on future versions? Sure > > I'm glad to see that this hardware allows all 16 IV bytes to be specified. > > Does it also handle programming and evicting keys efficiently? "efficiently" is a very subjective term. We are using FW command interface to program keys and this interface can do hundreds/thousands commands per-second. Thanks