public inbox for linux-nvme@lists.infradead.org
 help / color / mirror / Atom feed
From: Keith Busch <kbusch@kernel.org>
To: Alistair Francis <alistair23@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Klaus Jensen <its@irrelevant.dk>, Jens Axboe <axboe@fb.com>,
	Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
	linux-nvme@lists.infradead.org, qemu-block@nongnu.org,
	qemu-devel@nongnu.org
Subject: Re: completion timeouts with pin-based interrupts in QEMU hw/nvme
Date: Wed, 18 Jan 2023 21:03:39 -0700	[thread overview]
Message-ID: <Y8jBG/j8w2R43kYd@kbusch-mbp> (raw)
In-Reply-To: <CAKmqyKMveR=RD6fgnzY0SV39tofD+Ws_AbrSZXE_o4m=M6GZHg@mail.gmail.com>

On Thu, Jan 19, 2023 at 01:10:57PM +1000, Alistair Francis wrote:
> On Thu, Jan 19, 2023 at 12:44 PM Keith Busch <kbusch@kernel.org> wrote:
> >
> > Further up, it says the "interrupt gateway" is responsible for
> > forwarding new interrupt requests while the level remains asserted, but
> > it doesn't look like anything is handling that, which essentially turns
> > this into an edge interrupt. Am I missing something, or is this really
> > not being handled?
> 
> Yeah, that wouldn't be handled. In QEMU the PLIC relies on QEMUs
> internal GPIO lines to trigger an interrupt. So with the current setup
> we only support edge triggered interrupts.

Thanks for confirming!

Klaus,
I think we can justify introducing a work-around in the emulated device
now. My previous proposal with pci_irq_pulse() is no good since it does
assert+deassert, but it needs to be the other way around, so please
don't considert that one.

Also, we ought to revisit the intms/intmc usage in the linux driver for
threaded interrupts.


  reply	other threads:[~2023-01-19  4:23 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-12 13:10 completion timeouts with pin-based interrupts in QEMU hw/nvme Klaus Jensen
2023-01-12 14:26 ` Guenter Roeck
2023-01-12 16:34 ` Keith Busch
2023-01-12 17:45   ` Klaus Jensen
2023-01-12 17:51     ` Keith Busch
2023-01-12 19:14     ` Guenter Roeck
2023-01-12 19:27     ` Keith Busch
2023-01-13  0:27       ` Guenter Roeck
2023-01-12 23:57     ` Guenter Roeck
2023-01-13  8:54 ` Klaus Jensen
2023-01-13 12:32   ` Peter Maydell
2023-01-13 12:37     ` Klaus Jensen
2023-01-13 12:42       ` Peter Maydell
2023-01-13 12:46         ` Klaus Jensen
2023-01-13 16:52     ` Keith Busch
2023-01-16 21:14 ` Klaus Jensen
2023-01-17  4:58   ` Keith Busch
2023-01-17 16:09     ` Guenter Roeck
2023-01-17 16:18       ` Peter Maydell
2023-01-17 19:21         ` Guenter Roeck
2023-01-18 15:04           ` Peter Maydell
2023-01-18 16:33             ` Keith Busch
2023-01-18 23:06               ` Keith Busch
2023-01-19  0:41                 ` Alistair Francis
2023-01-19  2:44                   ` Keith Busch
2023-01-19  3:10                     ` Alistair Francis
2023-01-19  4:03                       ` Keith Busch [this message]
2023-01-19  7:28                         ` Klaus Jensen
2023-01-19  8:02                           ` Klaus Jensen
2023-01-19 14:32                             ` Guenter Roeck
2023-01-19 10:35                         ` Peter Maydell
2023-01-17 16:05   ` Guenter Roeck
2023-01-18  4:17 ` Keith Busch
2023-01-18 22:26 ` Keith Busch
2023-01-19  7:06   ` Klaus Jensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y8jBG/j8w2R43kYd@kbusch-mbp \
    --to=kbusch@kernel.org \
    --cc=alistair23@gmail.com \
    --cc=axboe@fb.com \
    --cc=hch@lst.de \
    --cc=its@irrelevant.dk \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux@roeck-us.net \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox