From: Klaus Jensen <its@irrelevant.dk>
To: linux-nvme@lists.infradead.org
Cc: Sagi Grimberg <sagi@grimberg.me>,
Klaus Jensen <k.jensen@samsung.com>,
linux-kernel@vger.kernel.org, Jens Axboe <axboe@fb.com>,
Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v2] nvme: allow use of cmb on v1.4 controllers
Date: Fri, 15 Jan 2021 07:32:18 +0100 [thread overview]
Message-ID: <YAE28i5Aq0U40fPB@apples.localdomain> (raw)
In-Reply-To: <20210115063046.274495-1-its@irrelevant.dk>
[-- Attachment #1.1: Type: text/plain, Size: 462 bytes --]
On Jan 15 07:30, Klaus Jensen wrote:
> From: Klaus Jensen <k.jensen@samsung.com>
>
> Since NVMe v1.4 the Controller Memory Buffer must be explicitly enabled
> by the host.
>
Sorry, messed up and missed adding the changes for v2.
v2:
- Do not explicitly check the NVMe version, rely on the presence of
the new register instead. (Christoph)
- Use hi_lo_writeq. (Christoph, Keith)
- Fix missing offset and use pci_bus_address(). (Keith)
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 158 bytes --]
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-01-15 6:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-15 6:30 [PATCH v2] nvme: allow use of cmb on v1.4 controllers Klaus Jensen
2021-01-15 6:32 ` Klaus Jensen [this message]
2021-01-18 17:59 ` Christoph Hellwig
2021-01-18 18:29 ` Klaus Jensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YAE28i5Aq0U40fPB@apples.localdomain \
--to=its@irrelevant.dk \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=k.jensen@samsung.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox