From: Klaus Jensen <its@irrelevant.dk>
To: Keith Busch <kbusch@kernel.org>
Cc: linux-nvme@lists.infradead.org, hch@lst.de, sagi@grimberg.me,
chaitanya.kulkarni@wdc.com, Yi Zhang <yi.zhang@redhat.com>
Subject: Re: [PATCH] nvmet: remove unsupported command noise
Date: Thu, 29 Apr 2021 08:36:28 +0200 [thread overview]
Message-ID: <YIpT7NFmkNc8EWfp@apples.localdomain> (raw)
In-Reply-To: <20210429042558.905404-1-kbusch@kernel.org>
[-- Attachment #1.1: Type: text/plain, Size: 1991 bytes --]
On Apr 28 21:25, Keith Busch wrote:
>Nothing can stop a host from submitting invalid commands. The target
>just needs to respond with an appropriate status, but that's not a
>target error. Demote invalid command messages to the debug level so
>these events don't spam the kernel logs.
>
>Reported-by: Yi Zhang <yi.zhang@redhat.com>
>Signed-off-by: Keith Busch <kbusch@kernel.org>
>---
> drivers/nvme/target/admin-cmd.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/drivers/nvme/target/admin-cmd.c b/drivers/nvme/target/admin-cmd.c
>index d2a26ff3f7b3..8175b61ae0a3 100644
>--- a/drivers/nvme/target/admin-cmd.c
>+++ b/drivers/nvme/target/admin-cmd.c
>@@ -307,7 +307,7 @@ static void nvmet_execute_get_log_page(struct nvmet_req *req)
> case NVME_LOG_ANA:
> return nvmet_execute_get_log_page_ana(req);
> }
>- pr_err("unhandled lid %d on qid %d\n",
>+ pr_debug("unhandled lid %d on qid %d\n",
> req->cmd->get_log_page.lid, req->sq->qid);
> req->error_loc = offsetof(struct nvme_get_log_page_command, lid);
> nvmet_req_complete(req, NVME_SC_INVALID_FIELD | NVME_SC_DNR);
>@@ -659,7 +659,7 @@ static void nvmet_execute_identify(struct nvmet_req *req)
> return nvmet_execute_identify_desclist(req);
> }
>
>- pr_err("unhandled identify cns %d on qid %d\n",
>+ pr_debug("unhandled identify cns %d on qid %d\n",
> req->cmd->identify.cns, req->sq->qid);
> req->error_loc = offsetof(struct nvme_identify, cns);
> nvmet_req_complete(req, NVME_SC_INVALID_FIELD | NVME_SC_DNR);
>@@ -977,7 +977,7 @@ u16 nvmet_parse_admin_cmd(struct nvmet_req *req)
> return 0;
> }
>
>- pr_err("unhandled cmd %d on qid %d\n", cmd->common.opcode,
>+ pr_debug("unhandled cmd %d on qid %d\n", cmd->common.opcode,
> req->sq->qid);
> req->error_loc = offsetof(struct nvme_common_command, opcode);
> return NVME_SC_INVALID_OPCODE | NVME_SC_DNR;
>--
>2.25.4
>
Reviewed-by: Klaus Jensen <k.jensen@samsung.com>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 158 bytes --]
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-04-29 6:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-29 4:25 [PATCH] nvmet: remove unsupported command noise Keith Busch
2021-04-29 6:36 ` Klaus Jensen [this message]
2021-04-29 18:17 ` Chaitanya Kulkarni
2021-05-04 7:41 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIpT7NFmkNc8EWfp@apples.localdomain \
--to=its@irrelevant.dk \
--cc=chaitanya.kulkarni@wdc.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=yi.zhang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox