From: Ming Lei <ming.lei@redhat.com>
To: Hannes Reinecke <hare@suse.de>
Cc: Jens Axboe <axboe@kernel.dk>,
Daniel Wagner <daniel.wagner@suse.com>,
Christoph Hellwig <hch@lst.de>,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
Wen Xiong <wenxiong@us.ibm.com>
Subject: Re: [PATCH] blk-mq: don't allocate requests when all cpus in a hctx are offline
Date: Wed, 30 Jun 2021 18:13:49 +0800 [thread overview]
Message-ID: <YNxD3ekRJrZK8FKm@T590> (raw)
In-Reply-To: <20210630100342.1100-1-hare@suse.de>
On Wed, Jun 30, 2021 at 12:03:42PM +0200, Hannes Reinecke wrote:
> When all CPUs in a hctx are offline in blk_mq_alloc_request_hctx() we should
> not try to allocate the request, as we'll fail later on in blk_mq_get_tag() anyway.
>
> Signed-off-by: Hannes Reinecke <hare@suse.de>
> ---
Please see my yesterday's reply why this way isn't good:
https://lore.kernel.org/lkml/YNrwnWfsxf8cJcoe@T590/
https://lore.kernel.org/lkml/YNrhXFgv%2FgEWbhbl@T590/
Thanks,
Ming
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
prev parent reply other threads:[~2021-06-30 10:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-30 10:03 [PATCH] blk-mq: don't allocate requests when all cpus in a hctx are offline Hannes Reinecke
2021-06-30 10:13 ` Ming Lei [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNxD3ekRJrZK8FKm@T590 \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=daniel.wagner@suse.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=wenxiong@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).