Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Padmakar Kalghatgi <p.kalghatgi@samsung.com>,
	qemu-devel@nongnu.org, kbusch@kernel.org, its@irrelevant.dk,
	fam@euphon.net, kwolf@redhat.com, mreitz@redhat.com,
	qemu-block@nongnu.org, linux-nvme@lists.infradead.org,
	k.jensen@samsung.com, javier.gonz@samsung.com,
	prakash.v@samsung.com, d.palani@samsung.com,
	u.kishore@samsung.com, mohit.kap@samsung.com,
	jg123.choi@samsung.com
Subject: Re: [RFC PATCH 1/2] hw/nvme: add mi device
Date: Tue, 13 Jul 2021 06:30:28 +0100	[thread overview]
Message-ID: <YO0k9JFO93EMaFIj@infradead.org> (raw)
In-Reply-To: <YOwhf59Xb/9IkZ9K@stefanha-x1.localdomain>

On Mon, Jul 12, 2021 at 12:03:27PM +0100, Stefan Hajnoczi wrote:
> Why did you decide to implement -device nvme-mi as a device on
> TYPE_NVME_BUS? If the NVMe spec somehow requires this then I'm surprised
> that there's no NVMe bus interface (callbacks). It seems like this could
> just as easily be a property of an NVMe controller -device
> nvme,mi=on|off or -device nvme-subsys,mi=on|off? I'm probably just not
> familiar enough with MI and NVMe architecture...

I'm too far away from qemu these days to understand what TYPE_NVME_BUS
is.  Bt NVMe-MI has tree possible transports:

 1) out of band through smbus.  This seems something that could be
    trivially modelled in qemu
 2) out of band over MCTP / PCIe VDM.
 3) in band using NVMe admin commands that pass through MI commands

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  reply	other threads:[~2021-07-13  5:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20210709135651epcas5p1c544dec5377413bfa4b2eeab6ee43f26@epcas5p1.samsung.com>
     [not found] ` <20210709135545.GA11148@test-zns>
2021-07-12 11:03   ` [RFC PATCH 1/2] hw/nvme: add mi device Stefan Hajnoczi
2021-07-13  5:30     ` Christoph Hellwig [this message]
2021-07-13  9:37       ` Stefan Hajnoczi
2021-07-15 14:37         ` Padmakar Kalghatgi
2021-07-15 12:36     ` Padmakar Kalghatgi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YO0k9JFO93EMaFIj@infradead.org \
    --to=hch@infradead.org \
    --cc=d.palani@samsung.com \
    --cc=fam@euphon.net \
    --cc=its@irrelevant.dk \
    --cc=javier.gonz@samsung.com \
    --cc=jg123.choi@samsung.com \
    --cc=k.jensen@samsung.com \
    --cc=kbusch@kernel.org \
    --cc=kwolf@redhat.com \
    --cc=linux-nvme@lists.infradead.org \
    --cc=mohit.kap@samsung.com \
    --cc=mreitz@redhat.com \
    --cc=p.kalghatgi@samsung.com \
    --cc=prakash.v@samsung.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=u.kishore@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox