From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F610C4338F for ; Tue, 24 Aug 2021 06:07:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6837F61262 for ; Tue, 24 Aug 2021 06:07:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6837F61262 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KIJDM5T2fKUSzhIAkqFY+UC3p5zKSO+onDyvzUGm3So=; b=DFUhqzXR76kcTl bMwTyisMqkDuJStV9EsHkXDxXwx2TDELKURrMfsQ8HHaGjt48TGjcFMotDGF11MQl/zH9l5oY8/ef bpZL/Rx6SRUnTS6UGa024grClTNNpN+EdV9lnqvnD4YCkUhxp79oT7W8VBW5uKjAQ6jN5h7YnY4mj 9F7F/2iIIJTYzOu91g5P8+fGE2W+rN91ixWPsnc06hysiMwyz8htR2HsFbD5inSET/YSa5opzxobV roSp4jpMX99m/fKgGnlxc7vy9Vr27YcHrC4tjqKc0l9W9ktfc6RkVCQLhJjs7q9G0uaiwXK05Y2Qu VvyZdNHtfl8tcMm4HpTQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mIPaQ-001myK-IL; Tue, 24 Aug 2021 06:07:02 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mIPaO-001mu9-H2 for linux-nvme@bombadil.infradead.org; Tue, 24 Aug 2021 06:07:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=hB8WPd6Dhr/hzdVtNS0ffJORtwM+dGiIjp94qlihQ7M=; b=WgCRa3BYVWnDsGW119DprPheIh uqOEofdHGp0kN0IU1bK5IlvfWwfmcVFK1hx9in5loYsHViWR/WvlCYdpGQ7YmjyjC8bd+fcWLSPGa uClfIyrRvRVjKNRfZLuptHDTJgR9vgNDeojTI4gnerytRXKu4KOQLc0Uw9mbKd9KAy1xxjJKLW2kJ /MoeboEAix2HE9CsHJHzowCAogH6N+6waOMm10TKd4vcG8pcAJVIiZ98gJNbtJBLh+23ZBXrEgip5 YCYjxYPIl2KNsdn8gQ2bV/4l9rfLzHqZAsnfVFR2xzfBhaZMNEoO6CBxLaoAOCg5GWY4TZ3Ls3ODg PPC03sAA==; Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mIPXm-00Acxa-5g; Tue, 24 Aug 2021 06:04:45 +0000 Date: Tue, 24 Aug 2021 07:04:18 +0100 From: Christoph Hellwig To: Luis Chamberlain Cc: axboe@kernel.dk, martin.petersen@oracle.com, jejb@linux.ibm.com, kbusch@kernel.org, sagi@grimberg.me, adrian.hunter@intel.com, beanhuo@micron.com, ulf.hansson@linaro.org, avri.altman@wdc.com, swboyd@chromium.org, agk@redhat.com, snitzer@redhat.com, josef@toxicpanda.com, hch@infradead.org, hare@suse.de, bvanassche@acm.org, ming.lei@redhat.com, linux-scsi@vger.kernel.org, linux-nvme@lists.infradead.org, linux-mmc@vger.kernel.org, dm-devel@redhat.com, nbd@other.debian.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 04/10] scsi/sr: add error handling support for add_disk() Message-ID: References: <20210823202930.137278-1-mcgrof@kernel.org> <20210823202930.137278-5-mcgrof@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210823202930.137278-5-mcgrof@kernel.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Mon, Aug 23, 2021 at 01:29:24PM -0700, Luis Chamberlain wrote: > We never checked for errors on add_disk() as this function > returned void. Now that this is fixed, use the shiny new > error handling. > > Signed-off-by: Luis Chamberlain Looks good, Reviewed-by: Christoph Hellwig _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme