From: Ming Lei <ming.lei@redhat.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Sagi Grimberg <sagi@grimberg.me>,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
linux-scsi@vger.kernel.org, Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH 1/5] blk-mq: move srcu from blk_mq_hw_ctx to request_queue
Date: Fri, 19 Nov 2021 16:10:03 +0800 [thread overview]
Message-ID: <YZdb2/XoJVJOa1r+@T590> (raw)
In-Reply-To: <a3192b20-fa76-0b64-a2a9-c0c337741156@acm.org>
On Thu, Nov 18, 2021 at 08:30:49PM -0800, Bart Van Assche wrote:
> On 11/18/21 18:18, Ming Lei wrote:
> > + bool alloc_srcu;
>
> I found the following statement multiple times in this patch:
>
> WARN_ON_ONCE(q->alloc_srcu != !!(q->tag_set->flags & BLK_MQ_F_BLOCKING));
>
> Does this mean that the new q->alloc_srcu member variable can be left out
> and that it can be replaced with the following test?
>
> q->tag_set->flags & BLK_MQ_F_BLOCKING
q->tag_set can't be used anymore after blk_cleanup_queue() returns,
and we need the flag for freeing request_queue instance.
>
> Please note that I'm not concerned about the memory occupied by this
> variable but only about avoiding redundancy.
>
> If this variable is retained it probably should be renamed, e.g. "has_srcu"
> instead of "alloc_srcu".
Fine.
Thanks,
Ming
next prev parent reply other threads:[~2021-11-19 8:10 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-19 2:18 [PATCH 0/5] blk-mq: quiesce improvement Ming Lei
2021-11-19 2:18 ` [PATCH 1/5] blk-mq: move srcu from blk_mq_hw_ctx to request_queue Ming Lei
2021-11-19 4:30 ` Bart Van Assche
2021-11-19 8:10 ` Ming Lei [this message]
2021-11-22 7:48 ` Sagi Grimberg
2021-11-22 13:08 ` Ming Lei
2021-11-22 13:47 ` Sagi Grimberg
2021-11-19 2:18 ` [PATCH 2/5] blk-mq: rename hctx_lock & hctx_unlock Ming Lei
2021-11-22 7:53 ` Sagi Grimberg
2021-11-22 13:20 ` Ming Lei
2021-11-22 13:50 ` Sagi Grimberg
2021-11-23 0:08 ` Ming Lei
2021-11-23 8:54 ` Sagi Grimberg
2021-11-22 9:00 ` Christoph Hellwig
2021-11-19 2:18 ` [PATCH 3/5] blk-mq: add helper of blk_mq_global_quiesce_wait() Ming Lei
2021-11-22 7:56 ` Sagi Grimberg
2021-11-22 8:00 ` Sagi Grimberg
2021-11-22 13:26 ` Ming Lei
2021-11-22 13:55 ` Sagi Grimberg
2021-11-23 0:17 ` Ming Lei
2021-11-23 9:00 ` Sagi Grimberg
2021-11-30 2:33 ` Ming Lei
2021-12-08 12:49 ` Sagi Grimberg
2021-12-10 2:02 ` Ming Lei
2021-11-19 2:18 ` [PATCH 4/5] nvme: quiesce namespace queue in parallel Ming Lei
2021-11-22 8:07 ` Sagi Grimberg
2021-11-23 0:13 ` Ming Lei
2021-11-19 2:18 ` [PATCH 5/5] scsi: use blk-mq quiesce APIs to implement scsi_host_block Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZdb2/XoJVJOa1r+@T590 \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox