From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CF697C433EF for ; Mon, 24 Jan 2022 23:28:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IlNQPGOZpWmo+k7nBEmHz0ohqpEuOKZGrpMVc+NcfrY=; b=cv+di34fWmc5OV4c8Zs8ZLNHC5 DydbXWtVbJvpYK+wenoOK1HQBGaW3VUrBcO2jBqur8xallmxYF7S9ja5S+y6QNPRvBHAa8Wdx3BsM 1ajqWpFHUbCtziskmx63ifKa+sdA39dMqvw6AY/G14VMLeW9GHHNnQGRKqPLiBMAeUhGf1ZQ7fsBf VdAw0fmKPvXFYgerH1AdgOgzsKmPkGcYM+Rc7LgXA+c2rbsXNXlOWYC1lt45pzxyOMq08MVZUkLR6 9HqICl+2weVEpOnREqLS81YU+dsHfalT4+gzyYnXhy0fkgNbxqjs4thsCSQfZ6IBG7FVyjzCRxwOf 3IIrtFBg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nC8kl-005aX0-O5; Mon, 24 Jan 2022 23:28:03 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nC8kj-005aWZ-La for linux-nvme@lists.infradead.org; Mon, 24 Jan 2022 23:28:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643066880; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IlNQPGOZpWmo+k7nBEmHz0ohqpEuOKZGrpMVc+NcfrY=; b=NjzQMGVz6hWLo9y1ebl5mppwuZ+b/sRo0D/Zgkwmlzr80WW12xzWzyyqVx2XKhUCppfPR3 Gt0SVlJBmRCFFJYFxygMRVsywtWadAc4mTtQHlsIR8lDuwJUCDy0TJXZlfkWzwMkCzjgN+ Qe1I6/h7KjJnqPEanTfcpgsiLWCHyvY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-385-S8mqnyQoPgqAjdxJr3dxPQ-1; Mon, 24 Jan 2022 18:27:57 -0500 X-MC-Unique: S8mqnyQoPgqAjdxJr3dxPQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 03D271006AA6; Mon, 24 Jan 2022 23:27:56 +0000 (UTC) Received: from T590 (ovpn-8-21.pek2.redhat.com [10.72.8.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7E2AC5DB95; Mon, 24 Jan 2022 23:27:42 +0000 (UTC) Date: Tue, 25 Jan 2022 07:27:37 +0800 From: Ming Lei To: Christoph Hellwig Cc: Jens Axboe , "Martin K . Petersen" , linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org Subject: Re: [PATCH V2 10/13] block: add helper of disk_release_queue for release queue data for disk Message-ID: References: <20220122111054.1126146-1-ming.lei@redhat.com> <20220122111054.1126146-11-ming.lei@redhat.com> <20220124131624.GI27269@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220124131624.GI27269@lst.de> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220124_152801_807765_0F9E4011 X-CRM114-Status: GOOD ( 17.40 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Mon, Jan 24, 2022 at 02:16:24PM +0100, Christoph Hellwig wrote: > On Sat, Jan 22, 2022 at 07:10:51PM +0800, Ming Lei wrote: > > Add one helper of disk_release_queue for releasing queue data for disk. > > Please explain what "queue data for disk" is, and why this helper is Here it means elevator, blk-cgroup and rq qos, all actually serve FS IOs, maybe it should be changed to FS IOs. > useful. Right now it seems to just move a few things around without a > rationale or explanation of why it is safe. This patch just moves two function calls into the helper, and there doesn't have functional change, so no need rationale and explanation. Thanks, Ming