From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 52558C433F5 for ; Tue, 22 Feb 2022 16:02:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:In-Reply-To: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7j5XB5PHt4v2EZRj2xa7IPpDQY6qbeddhaMQI3ZMvR8=; b=MXTVDTzbsLyQTukW4SadjjIMDw gj2WjtEav68/nYHeJV++VDC5aRPF0R/VcvTJrBPkpiqqXFxBSjKck0f+FRozoLl1g3ZkLTwZNbCv9 QL2470K4q6jR8dxL2OfVcJnOgbQU8cl+wbN5/uZ46Sb15/Qj05PNg0nOhoueqlHXgq/z7P6Brtqcv ylEPR4kJ9AERCGT4icVmfqF60xYooeg3FgB1sRk0oAxv9tb8oF1hg0ljGFXLJ8NGhEEnJJhqe0aqE wAVoZ/Nab+mXv6ZR0sEhf0Ot1DjiYw/LN7al2ADm1Q8Tbr2gGneoUpC1nhzPnSffLojnY+Swgbhhi mIyeIj2g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nMXcm-00AVOR-SL; Tue, 22 Feb 2022 16:02:49 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nMXag-00AUB2-Oq for linux-nvme@lists.infradead.org; Tue, 22 Feb 2022 16:00:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1645545636; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7j5XB5PHt4v2EZRj2xa7IPpDQY6qbeddhaMQI3ZMvR8=; b=P1LOSwcfexLJwJd0dGaQwlonvWsnBulUpiqkesstCpsFPVkBNEZqpXji3l1rwUxLyckoWh MKHr+bE9XzxtlkURRNuoby6gBjuZI3aUXNTOVI3gzMe3ITHD4cyxOTEVNL7knMhmmgvdWM bWiGKnzlFIaDD/xkwdaMyr4fEzAcwOI= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-54-5gpJg_GqMnyJ6qw9GJbUWQ-1; Tue, 22 Feb 2022 11:00:34 -0500 X-MC-Unique: 5gpJg_GqMnyJ6qw9GJbUWQ-1 Received: by mail-qv1-f69.google.com with SMTP id i20-20020a056214031400b0043185095fe2so9376290qvu.10 for ; Tue, 22 Feb 2022 08:00:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=7j5XB5PHt4v2EZRj2xa7IPpDQY6qbeddhaMQI3ZMvR8=; b=RRF9MjV1XO847eIObthJio2iWcvltlqIneWOJmSP9wNrqAvtE4nd4CsfpUjXtJjSoe do2B+mVPOWQYlqCPRsIxW6c3BbuKxayTxC0bwVl+HynwLSiJ1Ke97SgEXq109PRgS2zb pJetzPZL3B2h3v5uXFu53HKowkpwJJWbXgVJy6QbqQ2ho2Gg0YWPUr0FPMBOEsU0tZyo isBzOIlX8hgAKU7svZ4SeabKmG0PKIvWkY5QDilOQQqHEKLACtct5H9zvyuHzcnjr5Za UyR/zAgwZBrT+w6yZv18VjX96dec2QPXEQznImGi+ALnbEjw49xyW8qJJ6w1qzuUh7eo a9qA== X-Gm-Message-State: AOAM5333R2jFw/l6igs3/3v8nLID3cxszExR2x0dWWN/KmFTw3SIUrU6 NfHEvcJRaLhDrB0KazGOVxwIwGv7Dj0WyJ9MQaytUsSQar+BrVTADdhc3EfFNPfc/aTCrYo/G43 z+hZAryyGLETAed9vNrRIfnmw2w== X-Received: by 2002:a37:4646:0:b0:5e9:562c:ac48 with SMTP id t67-20020a374646000000b005e9562cac48mr16038772qka.140.1645545633644; Tue, 22 Feb 2022 08:00:33 -0800 (PST) X-Google-Smtp-Source: ABdhPJxryPhmCAvy6V12tr9ic0DJ2vhMYnP9pzcqZxnXZ3eH8/ot/d3iuhUAxdNQeoKTb7fJKlWKtg== X-Received: by 2002:a37:4646:0:b0:5e9:562c:ac48 with SMTP id t67-20020a374646000000b005e9562cac48mr16038726qka.140.1645545633187; Tue, 22 Feb 2022 08:00:33 -0800 (PST) Received: from localhost (pool-68-160-176-52.bstnma.fios.verizon.net. [68.160.176.52]) by smtp.gmail.com with ESMTPSA id h21sm18450qtb.13.2022.02.22.08.00.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Feb 2022 08:00:32 -0800 (PST) Date: Tue, 22 Feb 2022 11:00:31 -0500 From: Mike Snitzer To: Nitesh Shetty Cc: javier@javigon.com, chaitanyak@nvidia.com, linux-block@vger.kernel.org, linux-scsi@vger.kernel.org, dm-devel@redhat.com, linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org, axboe@kernel.dk, msnitzer@redhat.com, bvanassche@acm.org, martin.petersen@oracle.com, hare@suse.de, kbusch@kernel.org, hch@lst.de, Frederick.Knight@netapp.com, osandov@fb.com, lsf-pc@lists.linux-foundation.org, djwong@kernel.org, josef@toxicpanda.com, clm@fb.com, dsterba@suse.com, tytso@mit.edu, jack@suse.com, joshi.k@samsung.com, arnav.dawn@samsung.com, nitheshshetty@gmail.com, Alasdair Kergon , Sagi Grimberg , James Smart , Chaitanya Kulkarni , Alexander Viro , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 08/10] dm: Add support for copy offload. Message-ID: References: <20220214080002.18381-1-nj.shetty@samsung.com> <20220214080002.18381-9-nj.shetty@samsung.com> MIME-Version: 1.0 In-Reply-To: <20220214080002.18381-9-nj.shetty@samsung.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=snitzer@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220222_080038_992764_483FB8A7 X-CRM114-Status: GOOD ( 28.22 ) X-Mailman-Approved-At: Tue, 22 Feb 2022 08:02:43 -0800 X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Mon, Feb 14 2022 at 2:59P -0500, Nitesh Shetty wrote: > Before enabling copy for dm target, check if underlying devices and > dm target support copy. Avoid split happening inside dm target. > Fail early if the request needs split, currently splitting copy > request is not supported. > > Signed-off-by: Nitesh Shetty > --- > drivers/md/dm-table.c | 45 +++++++++++++++++++++++++++++++++++ > drivers/md/dm.c | 6 +++++ > include/linux/device-mapper.h | 5 ++++ > 3 files changed, 56 insertions(+) > > diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.c > index e43096cfe9e2..8dc9ae6a6a86 100644 > --- a/drivers/md/dm-table.c > +++ b/drivers/md/dm-table.c > @@ -1903,6 +1903,38 @@ static bool dm_table_supports_nowait(struct dm_table *t) > return true; > } > > +static int device_not_copy_capable(struct dm_target *ti, struct dm_dev *dev, > + sector_t start, sector_t len, void *data) > +{ > + struct request_queue *q = bdev_get_queue(dev->bdev); > + > + return !blk_queue_copy(q); > +} > + > +static bool dm_table_supports_copy(struct dm_table *t) > +{ > + struct dm_target *ti; > + unsigned int i; > + > + for (i = 0; i < dm_table_get_num_targets(t); i++) { > + ti = dm_table_get_target(t, i); > + > + if (!ti->copy_supported) > + return false; > + > + /* > + * target provides copy support (as implied by setting > + * 'copy_supported') and it relies on _all_ data devices having copy support. > + */ > + if (ti->copy_supported && > + (!ti->type->iterate_devices || > + ti->type->iterate_devices(ti, device_not_copy_capable, NULL))) > + return false; > + } > + > + return true; > +} > + > static int device_not_discard_capable(struct dm_target *ti, struct dm_dev *dev, > sector_t start, sector_t len, void *data) > { > @@ -2000,6 +2032,19 @@ int dm_table_set_restrictions(struct dm_table *t, struct request_queue *q, > } else > blk_queue_flag_set(QUEUE_FLAG_DISCARD, q); > > + if (!dm_table_supports_copy(t)) { > + blk_queue_flag_clear(QUEUE_FLAG_COPY, q); > + /* Must also clear discard limits... */ copy-and-paste mistake: s/discard/copy/ ^ > + q->limits.max_copy_sectors = 0; > + q->limits.max_hw_copy_sectors = 0; > + q->limits.max_copy_range_sectors = 0; > + q->limits.max_hw_copy_range_sectors = 0; > + q->limits.max_copy_nr_ranges = 0; > + q->limits.max_hw_copy_nr_ranges = 0; > + } else { > + blk_queue_flag_set(QUEUE_FLAG_COPY, q); > + } > + > if (dm_table_supports_secure_erase(t)) > blk_queue_flag_set(QUEUE_FLAG_SECERASE, q); > > diff --git a/drivers/md/dm.c b/drivers/md/dm.c > index ab9cc91931f9..3b4cd49c489d 100644 > --- a/drivers/md/dm.c > +++ b/drivers/md/dm.c > @@ -1372,6 +1372,12 @@ static int __split_and_process_non_flush(struct clone_info *ci) > if (__process_abnormal_io(ci, ti, &r)) > return r; > > + if ((unlikely(op_is_copy(ci->bio->bi_opf)) && > + max_io_len(ti, ci->sector) < ci->sector_count)) { > + DMERR("%s: Error IO size(%u) is greater than maximum target size(%llu)\n", > + __func__, ci->sector_count, max_io_len(ti, ci->sector)); > + return -EIO; > + } > len = min_t(sector_t, max_io_len(ti, ci->sector), ci->sector_count); > > r = __clone_and_map_data_bio(ci, ti, ci->sector, &len); There isn't a need for __func__ prefix here. You'll also need to rebase on latest dm-5.18 (or wait until 5.18 merge window opens) because there has been some conflicting changes since you posted. > diff --git a/include/linux/device-mapper.h b/include/linux/device-mapper.h > index b26fecf6c8e8..acfd4018125a 100644 > --- a/include/linux/device-mapper.h > +++ b/include/linux/device-mapper.h > @@ -362,6 +362,11 @@ struct dm_target { > * zone append operations using regular writes. > */ > bool emulate_zone_append:1; > + > + /* > + * copy offload is supported > + */ > + bool copy_supported:1; > }; Would prefer this be "copy_offload_supported". > > void *dm_per_bio_data(struct bio *bio, size_t data_size); > -- > 2.30.0-rc0 >