From: Keith Busch <kbusch@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: sagi@grimberg.me, linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme: cleanup how disk->disk_name is assigned
Date: Tue, 15 Mar 2022 09:45:03 -0600 [thread overview]
Message-ID: <YjC0f2WVMurUmtlK@C02CK6Q3MD6M> (raw)
In-Reply-To: <20220315145125.2586068-1-hch@lst.de>
On Tue, Mar 15, 2022 at 03:51:25PM +0100, Christoph Hellwig wrote:
> They way how assigning the disk name and commenting on why it is done
> is split over core.c and multipath.c seems to be rather confusing.
>
> Now that ns_head->disk always exists we can do all the work in core.c
> and have a single big comment explaining the issues.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks good.
Reviewed-by: Keith Busch <kbusch@kernel.org>
next prev parent reply other threads:[~2022-03-15 15:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-15 14:51 [PATCH] nvme: cleanup how disk->disk_name is assigned Christoph Hellwig
2022-03-15 15:45 ` Keith Busch [this message]
2022-03-15 21:59 ` Chaitanya Kulkarni
2022-03-16 8:43 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YjC0f2WVMurUmtlK@C02CK6Q3MD6M \
--to=kbusch@kernel.org \
--cc=hch@lst.de \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox