From: Klaus Jensen <its@irrelevant.dk>
To: Christoph Hellwig <hch@lst.de>
Cc: Keith Busch <kbusch@kernel.org>, Sagi Grimberg <sagi@grimberg.me>,
Luis Chamberlain <mcgrof@kernel.org>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH 3/3] nvme-pci: disable namespace identifiers for Qemu controllers
Date: Tue, 12 Apr 2022 22:43:45 +0200 [thread overview]
Message-ID: <YlXkgUBxo7AuJuMO@apples> (raw)
In-Reply-To: <20220412114533.GA31047@lst.de>
[-- Attachment #1: Type: text/plain, Size: 1095 bytes --]
On Apr 12 13:45, Christoph Hellwig wrote:
> On Tue, Apr 12, 2022 at 08:33:38AM +0200, Klaus Jensen wrote:
> > > + { PCI_VDEVICE(REDHAT, 0x0010), /* Qemu emulated controller */
> > > + .driver_data = NVME_QUIRK_BOGUS_NID, },
> > > { PCI_DEVICE(0x126f, 0x2263), /* Silicon Motion unidentified */
> > > .driver_data = NVME_QUIRK_NO_NS_DESC_LIST, },
> > > { PCI_DEVICE(0x1bb1, 0x0100), /* Seagate Nytro Flash Storage */
> > > --
> > > 2.30.2
> > >
> >
> > When I fix this in QEMU properly, can we move this quirk to the
> > core_quirks and match on firmware revision? That way I don't have to
> > request a new DID.
>
> Do we known that only one firmware revision reported by Qemu is actually
> broken? For now I'd like to get the regression fixed ASAP, and I don't
> think Qemu ever fully got identifiers right so far. We can always
> change it later if needed.
>
To my knowledge, QEMU has only ever used 1.0 in FR, but I will check.
In any case, I did not want you to change this *now*, so I am totally
fine with this getting changed later if required.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-04-12 20:44 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-12 6:11 quirk broken namespace identifiers Christoph Hellwig
2022-04-12 6:11 ` [PATCH 1/3] nvme: add a quirk to disable " Christoph Hellwig
2022-04-12 6:56 ` Chaitanya Kulkarni
2022-04-12 7:01 ` Christoph Hellwig
2022-04-12 10:25 ` Sagi Grimberg
2022-04-12 14:16 ` Keith Busch
2022-04-12 6:11 ` [PATCH 2/3] nvme-pci: disable namespace identifiers for the MAXIO MAP1202 Christoph Hellwig
2022-04-12 6:57 ` Chaitanya Kulkarni
2022-04-12 10:25 ` Sagi Grimberg
2022-04-12 6:11 ` [PATCH 3/3] nvme-pci: disable namespace identifiers for Qemu controllers Christoph Hellwig
2022-04-12 6:33 ` Klaus Jensen
2022-04-12 11:45 ` Christoph Hellwig
2022-04-12 20:43 ` Klaus Jensen [this message]
2022-04-12 10:25 ` Sagi Grimberg
-- strict thread matches above, loose matches on Subject: below --
2022-04-13 4:49 quirk broken namespace identifiers v2 Christoph Hellwig
2022-04-13 4:49 ` [PATCH 3/3] nvme-pci: disable namespace identifiers for Qemu controllers Christoph Hellwig
2022-04-13 7:34 ` Niklas Cassel
2022-04-13 8:40 ` Klaus Jensen
2022-04-13 15:34 ` Christoph Hellwig
2022-04-13 15:49 ` Klaus Jensen
2022-04-13 15:50 ` Christoph Hellwig
2022-04-13 20:08 ` Klaus Jensen
2022-04-13 20:38 ` Keith Busch
2022-04-14 4:19 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlXkgUBxo7AuJuMO@apples \
--to=its@irrelevant.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mcgrof@kernel.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox