From: Christoph Hellwig <hch@infradead.org>
To: Vincent Fu <vincent.fu@samsung.com>
Cc: "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH] nvme: have nvme_setup_rw return BLK_STS_OK
Date: Thu, 28 Apr 2022 08:07:53 -0700 [thread overview]
Message-ID: <YmqtycoRZO3yxVCW@infradead.org> (raw)
In-Reply-To: <20220418194324.589248-1-vincent.fu@samsung.com>
On Mon, Apr 18, 2022 at 07:43:50PM +0000, Vincent Fu wrote:
> Return BLK_STS_OK instead of 0 on success. Since BLK_STS_OK is defined
> as 0 this patch results in no functional change but to avoid confusion
> and to be consistent with nvme_setup_write_zeroes as well as
> nvme_setup_discard we should have nvme_setup_rw also return BLK_STS_OK.
I really don't see the point. blk_status_t like all __bitwise types
is designed to be able to cope with a plain 0 just fine.
next prev parent reply other threads:[~2022-04-28 15:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220418194351uscas1p18e05fad61bc279e8ea18d1a1a8597dc3@uscas1p1.samsung.com>
2022-04-18 19:43 ` [PATCH] nvme: have nvme_setup_rw return BLK_STS_OK Vincent Fu
2022-04-19 14:16 ` Pankaj Raghav
2022-04-26 14:14 ` Sagi Grimberg
2022-04-28 15:07 ` Christoph Hellwig [this message]
2022-04-28 15:24 ` Vincent Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmqtycoRZO3yxVCW@infradead.org \
--to=hch@infradead.org \
--cc=linux-nvme@lists.infradead.org \
--cc=vincent.fu@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox