From: Christoph Hellwig <hch@infradead.org>
To: Tom Yan <tom.ty89@gmail.com>
Cc: linux-nvme@lists.infradead.org
Subject: Re: [PATCH v2] nvme: fix interpretation of dmrsl
Date: Thu, 28 Apr 2022 08:10:27 -0700 [thread overview]
Message-ID: <YmquYxXtGXlNB0PL@infradead.org> (raw)
In-Reply-To: <20220421084841.2106-1-tom.ty89@gmail.com>
This doesn't even compile:
drivers/nvme/host/core.c: In function ‘nvme_config_discard’:
drivers/nvme/host/core.c:1638:2: error: ISO C90 forbids mixed
declarations and code [-Werror=declaration-after-statement]
1638 | int lts_shift = ilog2(size) - 9;
| ^~~
next prev parent reply other threads:[~2022-04-28 15:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-21 8:48 [PATCH v2] nvme: fix interpretation of dmrsl Tom Yan
2022-04-28 15:10 ` Christoph Hellwig [this message]
2022-04-28 16:50 ` [PATCH v3] " Tom Yan
2022-04-28 17:18 ` Keith Busch
2022-04-29 4:52 ` [PATCH v4] " Tom Yan
2022-04-29 5:01 ` Tom Yan
2022-05-10 6:04 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmquYxXtGXlNB0PL@infradead.org \
--to=hch@infradead.org \
--cc=linux-nvme@lists.infradead.org \
--cc=tom.ty89@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox