From: Keith Busch <kbusch@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Keith Busch <kbusch@fb.com>, linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme: set dma alignment to 3
Date: Thu, 5 May 2022 10:31:09 -0600 [thread overview]
Message-ID: <YnP7zVFiD2j5t1bv@kbusch-mbp> (raw)
In-Reply-To: <20220505134533.GA13926@lst.de>
On Thu, May 05, 2022 at 03:45:34PM +0200, Christoph Hellwig wrote:
> On Wed, May 04, 2022 at 11:43:25AM -0700, Keith Busch wrote:
> > From: Keith Busch <kbusch@kernel.org>
> >
> > The nvme specification only requires qword alignment for segment
> > descriptors, and the driver already guarantees that. The spec has always
> > allowed user data to be dword aligned, which is what the queue's
> > attribute is for, so relax the alignment requirement to that value.
> >
> > While we could allow byte alignment for some controllers when using
> > SGLs, we still need to support PRP, and that only allows dword.
>
> Can't we just turn it go up to eleven? ;-)
Excellent idea! Best I can do is a binary 11 :p
next prev parent reply other threads:[~2022-05-05 16:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-04 18:43 [PATCH] nvme: set dma alignment to 3 Keith Busch
2022-05-05 13:45 ` Christoph Hellwig
2022-05-05 16:31 ` Keith Busch [this message]
2022-05-05 14:56 ` Jonathan Derrick
2022-05-10 6:19 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnP7zVFiD2j5t1bv@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=hch@lst.de \
--cc=kbusch@fb.com \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox