From: Klaus Jensen <its@irrelevant.dk>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-nvme@lists.infradead.org, Keith Busch <kbusch@kernel.org>,
Jens Axboe <axboe@fb.com>, Sagi Grimberg <sagi@grimberg.me>
Subject: Re: issuing flush to all namespaces
Date: Thu, 14 Jul 2022 10:16:19 +0200 [thread overview]
Message-ID: <Ys/Q08orzDQgIp4X@apples> (raw)
In-Reply-To: <20220714081103.GA30086@lst.de>
[-- Attachment #1: Type: text/plain, Size: 878 bytes --]
On Jul 14 10:11, Christoph Hellwig wrote:
> On Thu, Jul 14, 2022 at 10:08:41AM +0200, Klaus Jensen wrote:
> > Hi,
> >
> > Since the (very reasonable) changes that cause the driver to check that
> > the nsid of the command corresponds to the nsid of the namespace being
> > targeted it is no longer possible to issue a flush to all namespaces:
> >
> > # nvme flush /dev/nvme0n1 -n 0xffffffff
> > flush: Invalid argument
> >
> > Now, I think we can all agree that Flush is the odd one out here, but
> > can we do anything about it? The char devices also check the nsid, so
> > they can't be used either.
>
> Don't do it. Sending flush to all namespaces wasn't even clearly
> defined until I think NVMe 1.4 with the supported bits. It doesn't
> really make much sense and there is no point in supporting it in Linux.
Alright, I hear you :) Thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2022-07-14 8:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-14 8:08 issuing flush to all namespaces Klaus Jensen
2022-07-14 8:11 ` Christoph Hellwig
2022-07-14 8:16 ` Klaus Jensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ys/Q08orzDQgIp4X@apples \
--to=its@irrelevant.dk \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox