Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Justin Stitt <justinstitt@google.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-nvme@lists.infradead.org, linux@roeck-us.net, hare@suse.de,
	sagi@grimberg.me
Subject: Re: [PATCH] nvmet: fix a format specifier in nvmet_auth_ctrl_exponential
Date: Mon, 1 Aug 2022 11:19:39 -0700	[thread overview]
Message-ID: <YugWEHx+Myhtfv7v@google.com> (raw)
In-Reply-To: <20220718050356.227647-1-hch@lst.de>

On Mon, Jul 18, 2022 at 07:03:56AM +0200, Christoph Hellwig wrote:
> dh_keysize is a size_t, use the proper format specifier for printing it.
> 
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  drivers/nvme/target/auth.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/nvme/target/auth.c b/drivers/nvme/target/auth.c
> index b41c7bbcc4366..cf690df347758 100644
> --- a/drivers/nvme/target/auth.c
> +++ b/drivers/nvme/target/auth.c
> @@ -488,7 +488,7 @@ int nvmet_auth_ctrl_exponential(struct nvmet_req *req,
>  		return -ENOKEY;
>  	}
>  	if (buf_size != ctrl->dh_keysize) {
> -		pr_warn("ctrl %d DH public key size mismatch, need %lu is %d\n",
> +		pr_warn("ctrl %d DH public key size mismatch, need %zu is %d\n",
>  			ctrl->cntlid, ctrl->dh_keysize, buf_size);
>  		ret = -EINVAL;
>  	} else {
> -- 
> 2.30.2
> 
> 
> 
This patch runs parallel to our efforts to re-enable -Wformat.
See here: https://lore.kernel.org/all/20220720232332.2720091-1-justinstitt@google.com/

Hopefully this patch gets picked up by a maintainer so that Masahiro can
stage a clean PR re-enabling the -Wformat warning.

Reviewed-by: Justin Stitt <justinstitt@google.com>


  parent reply	other threads:[~2022-08-01 18:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-18  5:03 [PATCH] nvmet: fix a format specifier in nvmet_auth_ctrl_exponential Christoph Hellwig
2022-07-18  5:55 ` Guenter Roeck
2022-07-18  6:27 ` Hannes Reinecke
2022-07-18 21:32 ` Chaitanya Kulkarni
2022-07-21 22:19 ` Sagi Grimberg
2022-08-01 18:19 ` Justin Stitt [this message]
2022-08-01 18:24 ` Justin Stitt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YugWEHx+Myhtfv7v@google.com \
    --to=justinstitt@google.com \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux@roeck-us.net \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox