From: Keith Busch <kbusch@kernel.org>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: linux-nvme@lists.infradead.org, Christoph Hellwig <hch@lst.de>,
Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
Hannes Reinecke <hare@suse.de>,
Yogev Cohen <yogev@lightbitslabs.com>
Subject: Re: [PATCH] nvme-multipath: fix possible hang in live ns resize with ANA access
Date: Wed, 28 Sep 2022 11:21:36 -0600 [thread overview]
Message-ID: <YzSCoDP2PO7jIRLT@kbusch-mbp.dhcp.thefacebook.com> (raw)
In-Reply-To: <20220928135816.132213-1-sagi@grimberg.me>
On Wed, Sep 28, 2022 at 04:58:16PM +0300, Sagi Grimberg wrote:
> @@ -172,16 +172,18 @@ void nvme_mpath_clear_ctrl_paths(struct nvme_ctrl *ctrl)
> void nvme_mpath_revalidate_paths(struct nvme_ns *ns)
> {
> struct nvme_ns_head *head = ns->head;
> + struct nvme_ns *n;
> sector_t capacity = get_capacity(head->disk);
> int node;
Cosmetic nit, the new declaration ought to be below the capacity line for
reverse-xmas tree goodness.
next prev parent reply other threads:[~2022-09-28 17:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 13:58 [PATCH] nvme-multipath: fix possible hang in live ns resize with ANA access Sagi Grimberg
2022-09-28 17:02 ` Daniel Wagner
2022-09-28 17:14 ` Christoph Hellwig
2022-09-28 20:07 ` Sagi Grimberg
2022-09-28 17:21 ` Keith Busch [this message]
2022-09-28 20:06 ` Sagi Grimberg
2022-09-30 6:29 ` Hannes Reinecke
2022-09-30 6:40 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzSCoDP2PO7jIRLT@kbusch-mbp.dhcp.thefacebook.com \
--to=kbusch@kernel.org \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=yogev@lightbitslabs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox