public inbox for linux-nvme@lists.infradead.org
 help / color / mirror / Atom feed
From: Keith Busch <kbusch@kernel.org>
To: Maurizio Lombardi <mlombard@redhat.com>
Cc: axboe@kernel.dk, hch@lst.de, sagi@grimberg.me,
	linux-nvme@lists.infradead.org, kanie@linux.alibaba.com,
	kch@nvidia.com, loberman@redhat.com, emilne@redhat.com,
	jmeneghi@redhat.com
Subject: Re: [PATCH V2] nvme-fabrics: handle zero MAXCMD without closing the connection
Date: Wed, 4 Dec 2024 09:20:36 -0800	[thread overview]
Message-ID: <Z1CPZBhMfBNk3ifl@kbusch-mbp> (raw)
In-Reply-To: <20241203125732.393992-1-mlombard@redhat.com>

On Tue, Dec 03, 2024 at 01:57:32PM +0100, Maurizio Lombardi wrote:
> The NVMe specification states that MAXCMD is mandatory
> for NVMe-over-Fabrics implementations. However, some NVMe/TCP
> and NVMe/FC arrays from major vendors have buggy firmware
> that reports MAXCMD as zero in the Identify Controller data structure.
> 
> Currently, the host implementation returns an error in such cases,
> completely preventing the host from connecting to the target.
> 
> Fix the issue by printing a clear warning message about the firmware bug
> and allowing the connection to proceed. It assumes that the
> target supports a MAXCMD value of SQSIZE + 1. If any issues arise,
> the user can manually adjust SQSIZE to mitigate them.

Thanks, applied to nvme-6.13.


      parent reply	other threads:[~2024-12-04 17:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-03 12:57 [PATCH V2] nvme-fabrics: handle zero MAXCMD without closing the connection Maurizio Lombardi
2024-12-04  0:19 ` Christoph Hellwig
2024-12-04 17:20 ` Keith Busch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z1CPZBhMfBNk3ifl@kbusch-mbp \
    --to=kbusch@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=emilne@redhat.com \
    --cc=hch@lst.de \
    --cc=jmeneghi@redhat.com \
    --cc=kanie@linux.alibaba.com \
    --cc=kch@nvidia.com \
    --cc=linux-nvme@lists.infradead.org \
    --cc=loberman@redhat.com \
    --cc=mlombard@redhat.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox