From: Yongsoo Joo <ysjoo@kookmin.ac.kr>
To: Christoph Hellwig <hch@lst.de>
Cc: Keith Busch <kbusch@kernel.org>,
axboe@kernel.dk, sagi@grimberg.me,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme: fix return type of nvme_poll()
Date: Mon, 9 Dec 2024 13:28:04 +0000 [thread overview]
Message-ID: <Z1bwZKaEimphzLjq@ubuntu> (raw)
In-Reply-To: <20241209075836.GA24705@lst.de>
On Mon, Dec 09, 2024 at 08:58:36AM +0100, Christoph Hellwig wrote:
> On Sun, Dec 08, 2024 at 06:24:30AM +0000, Yongsoo Joo wrote:
> > I agree that all the "current" interested callers seem to expect
> > boolean-like return values from nvme_poll(). However, the return
> > type of both nvme_poll() and nvme_poll_cq() is int, and
> > nvme_poll_cq() actually returns the number of processed CQEs.
>
> Maybe add a patch to switch the poll method to return bool instead?
>
Thank you for your suggestion. I will submit a revised patch soon,
addressing the concern using the word 'fix' and the suggestion to
return bool.
--
prev parent reply other threads:[~2024-12-09 13:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-07 4:55 [PATCH] nvme: fix return type of nvme_poll() Yongsoo Joo
2024-12-08 3:13 ` Keith Busch
2024-12-08 6:24 ` Yongsoo Joo
2024-12-09 7:58 ` Christoph Hellwig
2024-12-09 13:28 ` Yongsoo Joo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1bwZKaEimphzLjq@ubuntu \
--to=ysjoo@kookmin.ac.kr \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox