From: Keith Busch <kbusch@kernel.org>
To: Yongsoo Joo <ysjoo@kookmin.ac.kr>
Cc: axboe@kernel.dk, hch@lst.de, sagi@grimberg.me,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH v3] nvme: change return type of nvme_poll_cq() to bool
Date: Tue, 7 Jan 2025 09:48:21 -0700 [thread overview]
Message-ID: <Z31a1eE80KswWyaJ@kbusch-mbp> (raw)
In-Reply-To: <20241223010516.241581-1-ysjoo@kookmin.ac.kr>
On Mon, Dec 23, 2024 at 01:05:17AM +0000, Yongsoo Joo wrote:
> The nvme_poll_cq() function currently returns the number of CQEs
> found, However, only one caller, nvme_poll(), requires a boolean
> value to check whether any CQE was completed. The other callers do
> not use the return value at all.
>
> To better reflect its usage, update the return type of nvme_poll_cq()
> from int to bool.
Thanks, applied to nvme-6.14.
prev parent reply other threads:[~2025-01-07 17:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-23 1:05 [PATCH v3] nvme: change return type of nvme_poll_cq() to bool Yongsoo Joo
2024-12-23 8:53 ` Christoph Hellwig
2024-12-24 10:07 ` Sagi Grimberg
2025-01-07 16:48 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z31a1eE80KswWyaJ@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=ysjoo@kookmin.ac.kr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox