From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3A9F8E77188 for ; Wed, 8 Jan 2025 10:33:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Ssv5sraZs0pWcRroM+g30CQn3Ui595UuxeM0/77A8ks=; b=NXjNCwerKJQGMR9JT9j2KOcMkb 2x926NfAaErtKv5zeSJXaTz8Cqgl2luzU/8Y4u6ZFWWdtJOlXx7jUxii9rMTkNG983eTd5qSqoPK/ J0kzOS+96t1Wer4+lrn8oTsovwDs8x0X87ujw9kzi7xJlKsUCGCL3siNtNZ6VHHVXY4mRmTo1M2Ww 61CIjknPhtfJCKw7ghK+NltUmBrXivMHtnqjzfROhdkmm3KKW3NgPfbo5KOAL3P+S1W9oRoWgwe6L WVCzAr3uWrjs1+slEWUjQvqtH+hWXK+bWR3dzM127RF+LqRmIM8kb8ChzK5jqr4Mmfnrl+2MTRS0C ftMxq6XQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tVTNp-00000007zrB-37cT; Wed, 08 Jan 2025 10:33:53 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tVTNn-00000007zqm-1iow for linux-nvme@lists.infradead.org; Wed, 08 Jan 2025 10:33:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736332430; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ssv5sraZs0pWcRroM+g30CQn3Ui595UuxeM0/77A8ks=; b=a+/YuC3ZkUVz6buPSyDMc9uJAxQXrUX0a7bE2kiegvSsFsJAczJfpUUfWecurSk3loj3Xd pv0xuw7bFM7FPcTZUUNg7qCF3mK80fQiSdRQlDoKtNLpT/V8Uy9MwienHgii5tZh/mp7ii /aOGar6fsrdJjKidUf7Cm1pukbUSdFA= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-622-Xkn6sEqxNDWEm0i-nMmU3A-1; Wed, 08 Jan 2025 05:33:48 -0500 X-MC-Unique: Xkn6sEqxNDWEm0i-nMmU3A-1 X-Mimecast-MFC-AGG-ID: Xkn6sEqxNDWEm0i-nMmU3A Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 25F1A19560B0; Wed, 8 Jan 2025 10:33:46 +0000 (UTC) Received: from fedora (unknown [10.72.116.74]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0EC57195608D; Wed, 8 Jan 2025 10:33:39 +0000 (UTC) Date: Wed, 8 Jan 2025 18:33:34 +0800 From: Ming Lei To: Christoph Hellwig Cc: Jens Axboe , Damien Le Moal , Nilay Shroff , linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, nbd@other.debian.org, linux-scsi@vger.kernel.org, usb-storage@lists.one-eyed-alien.net Subject: Re: [PATCH 04/10] block: add a store_limit operations for sysfs entries Message-ID: References: <20250108092520.1325324-1-hch@lst.de> <20250108092520.1325324-5-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250108092520.1325324-5-hch@lst.de> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250108_023351_523679_AB67526C X-CRM114-Status: GOOD ( 14.81 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Wed, Jan 08, 2025 at 10:25:01AM +0100, Christoph Hellwig wrote: > De-duplicate the code for updating queue limits by adding a store_limit > method that allows having common code handle the actual queue limits > update. > > Note that this is a pure refactoring patch and does not address the > existing freeze vs limits lock order problem in the refactored code, > which will be addressed next. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Damien Le Moal > Reviewed-by: Nilay Shroff Reviewed-by: Ming Lei Thanks, Ming