From: Keith Busch <kbusch@kernel.org>
To: Nilay Shroff <nilay@linux.ibm.com>
Cc: Keith Busch <kbusch@meta.com>,
linux-nvme@lists.infradead.org, hch@lst.de, sagi@grimberg.me
Subject: Re: [PATCH] nvme-pci: fix stuck reset on concurrent DPC and HP
Date: Mon, 10 Mar 2025 08:38:42 -0600 [thread overview]
Message-ID: <Z875cm31GNSTaiOg@kbusch-mbp> (raw)
In-Reply-To: <3dcf210e-a714-4572-bd5b-01c66c594fd9@linux.ibm.com>
On Sat, Mar 08, 2025 at 12:57:50PM +0530, Nilay Shroff wrote:
> On 3/7/25 8:54 PM, Keith Busch wrote:
> > If the pciehp removal starts after reset work's controller
> > initialization, then nothing stops the work from sending new admin
> > commands, and nothing will complete them. This causes the error_resume
> > to wait for something that will never happen.
>
> Ok makes sense, this appears to be a tight race condition and may not be
> limited to one platform. This should be possible even on PPC.
Yeah, I also thought it was a very unlikely condition to hit, but I have
a platform that deadlocks here almost every time a DPC event occurs.
prev parent reply other threads:[~2025-03-10 15:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-07 0:24 [PATCH] nvme-pci: fix stuck reset on concurrent DPC and HP Keith Busch
2025-03-07 12:58 ` Nilay Shroff
2025-03-07 15:24 ` Keith Busch
2025-03-08 7:27 ` Nilay Shroff
2025-03-10 14:38 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z875cm31GNSTaiOg@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=hch@lst.de \
--cc=kbusch@meta.com \
--cc=linux-nvme@lists.infradead.org \
--cc=nilay@linux.ibm.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox