From: Keith Busch <kbusch@kernel.org>
To: Meir Elisha <meir.elisha@volumez.com>
Cc: Christoph Hellwig <hch@lst.de>,
Chaitanya Kulkarni <kch@nvidia.com>,
Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH v3] nvmet-tcp: Fix a possible sporadic response drops in weakly ordered arch
Date: Fri, 28 Feb 2025 11:00:13 -0700 [thread overview]
Message-ID: <Z8H5rfGoMEagAHb_@kbusch-mbp> (raw)
In-Reply-To: <20250226072812.46089-1-meir.elisha@volumez.com>
On Wed, Feb 26, 2025 at 09:28:12AM +0200, Meir Elisha wrote:
> The order in which queue->cmd and rcv_state are updated is crucial.
> If these assignments are reordered by the compiler, the worker might not
> get queued in nvmet_tcp_queue_response(), hanging the IO. to enforce the
> the correct reordering, set rcv_state using smp_store_release().
>
> Fixes: bdaf13279192 ("nvmet-tcp: fix a segmentation fault during io parsing error")
Thanks, applied to nvme-6.14.
prev parent reply other threads:[~2025-02-28 18:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-26 7:28 [PATCH v3] nvmet-tcp: Fix a possible sporadic response drops in weakly ordered arch Meir Elisha
2025-02-27 9:09 ` Meir Elisha
2025-02-27 10:02 ` Sagi Grimberg
2025-02-28 18:00 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8H5rfGoMEagAHb_@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=hch@lst.de \
--cc=kch@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=meir.elisha@volumez.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox