From: Christoph Hellwig <hch@infradead.org>
To: Martin George <martinus.gpy@gmail.com>
Cc: linux-nvme@lists.infradead.org, Martin George <marting@netapp.com>
Subject: Re: [PATCH] nvme-core: avoid identify with CNS 06h to discovery controller
Date: Wed, 15 Mar 2023 06:47:43 -0700 [thread overview]
Message-ID: <ZBHMf5qBgsbhtk6N@infradead.org> (raw)
In-Reply-To: <20230311172603.3800-1-marting@netapp.com>
On Sat, Mar 11, 2023 at 10:56:03PM +0530, Martin George wrote:
> nvme_init_non_mdts_limits() currenty invokes an identify command with
> CNS 06h to both discovery and i/o controllers. But as per the NVMe-oF
> specification, this is not supported on discovery controllers:
>
> "The Discovery controller shall support the Identify command with a
> CNS value of 01h (Identify Controller data structure); all other CNS
> values are reserved."
>
> So ensure this identify command with CNS 06h is sent to i/o controllers
> alone and not to discovery controllers.
This looks correct, but can we go a step further and also skip it
for administrative controllers, i.e
> - if (nvme_ctrl_limited_cns(ctrl))
> + if (nvme_ctrl_limited_cns(ctrl) || nvme_discovery_ctrl(ctrl))
if (ctrl->subsys->subtype != NVME_NQN_NVME ||
nvme_ctrl_limited_cns(ctrl))
?
next prev parent reply other threads:[~2023-03-15 13:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-11 17:26 [PATCH] nvme-core: avoid identify with CNS 06h to discovery controller Martin George
2023-03-15 13:47 ` Christoph Hellwig [this message]
2023-03-16 8:34 ` Martin George
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBHMf5qBgsbhtk6N@infradead.org \
--to=hch@infradead.org \
--cc=linux-nvme@lists.infradead.org \
--cc=marting@netapp.com \
--cc=martinus.gpy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).