Re: [PATCH v1 1/2] nvme/rc: Parse optional arguments in _nvme_connect_subsys()

Daniel Wagner
2023-03-21T07:20:46Z

On Tue, Mar 21, 2023 at 05:16:25AM +0000, Chaitanya Kulkarni wrote:
> > + set -- "${positional_args[@]}"
> > +
> > local trtype="$1"
> > local subsysnqn="$2"
> > local traddr="${3:-$def_traddr}"
>
> can we please have all variable declarations at the start of the
> function then add the actual code instead of adding in between
> different variable declarations ??

Sure, though the assigment can't be at the beginning, we need to
go through the parser step first.