From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1AF68C6FD1D for ; Wed, 22 Mar 2023 00:18:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:In-Reply-To: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/jWDniPiD3ArKxuqWUYL+U69T82M+y4H2QrzlqkdHAY=; b=Xd6IVhmb35p64Qpi0sWxqSvvF7 o6/4O3/EHAxyzSjqe7tL2Ba6IsL1m8t32oPRzdIMLVm0v5/8LD4tQFxFX/S2uAHs4Nyu1zxwysn2J POJucVXyC2Ii7hj73iOUbU9IzN82lKsvwYZHVwPsHqgUKJjEaqPYsXqSnWh3L6lf9a8/Zq3G6h968 +Nm8G+r6GOrhIGC4nFTn6AyFvtfyJp4Nu9fYjVcz9ZRmH4ZUZi4FBtpIXmxGes1GrUTbIbvOPBQqs 0yS4uUHBi+WNfheyj8NUPEPwf80H4UQ6tuGmfzioS4o9/j0UsxfoACXqEi8lvRSxmLWnXPOlVhtG8 yolt95fA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pemBL-00E8tp-0d; Wed, 22 Mar 2023 00:18:23 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pemBI-00E8tI-1Y for linux-nvme@lists.infradead.org; Wed, 22 Mar 2023 00:18:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679444298; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/jWDniPiD3ArKxuqWUYL+U69T82M+y4H2QrzlqkdHAY=; b=XkAl8vWCg36gvZpybWh+Jl7T2nM5YgwBYTqtGKqo3JG0hfF+rbxxeUI4aAvOF7YKrdWccc FDQqbtz6oHvcj68C+K8NuneFuvNGgJoBBzz+Vhmdo4TFDdi/rg3VE0rtbeKdvHNRwmqJD+ +Q8pD/l1qi31RlKhSk416BEDOUb020A= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-272-vCb3AvyeOO2aOqpdADWFDw-1; Tue, 21 Mar 2023 20:18:12 -0400 X-MC-Unique: vCb3AvyeOO2aOqpdADWFDw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 031E4101A531; Wed, 22 Mar 2023 00:18:11 +0000 (UTC) Received: from localhost (unknown [10.2.17.90]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C421340C83A9; Wed, 22 Mar 2023 00:18:09 +0000 (UTC) Date: Tue, 21 Mar 2023 17:18:08 -0700 From: Chris Leech To: Hannes Reinecke Cc: Sagi Grimberg , Christoph Hellwig , Keith Busch , linux-nvme@lists.infradead.org, Chuck Lever , kernel-tls-handshake@lists.linux.dev Subject: Re: [PATCH 06/18] nvme-tcp: call 'queue->data_ready()' in nvme_tcp_data_ready() Message-ID: References: <20230321124325.77385-1-hare@suse.de> <20230321124325.77385-7-hare@suse.de> <3bd2c6b4-b276-b882-6f28-998118f96650@suse.de> MIME-Version: 1.0 In-Reply-To: <3bd2c6b4-b276-b882-6f28-998118f96650@suse.de> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230321_171820_619156_A851392E X-CRM114-Status: GOOD ( 22.27 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Tue, Mar 21, 2023 at 03:09:06PM +0100, Hannes Reinecke wrote: > On 3/21/23 14:44, Sagi Grimberg wrote: > > > > > Call the original data_ready() callback in nvme_tcp_data_ready() > > > to avoid a receive stall. > > > > Can you please improve the description to include what is the stall? > > For example, does the stall exist today? If it is, I would like to > > separate such patches from this set and include them asap. > > > That is actually particular to the TLS implementation, as it uses the > 'data_ready' callback to produce the data which can be read by eg recvmsg(). > > Without this call there's no data to peruse for recvmsg(). > > But I'm not _that_ deep into networking details to know whether this is TLS > specific or an issue with any data_ready callback. > I assume the latter, but then again, who knows. > > Hence the slightly vague description. This looks like the socket callbacks end up hooked in the wrong order. Ideally it would be tcp -> tls -> nvme_tcp, while this currently looks like tcp -> nvme_tcp and then this call back to tls for decryption. I'm not quite sure how to untangle this; nvme_tcp can't just set it's own callbacks before initializing kTLS, becuse that's being done by tlshd which is going to need the userspace socket API callbacks working. - Chris