Re: [RFC v3 1/1] nvme: add passthrough error logging opt-in

alan.adamson
2023-04-03T22:55:12Z

On 4/3/23 3:38 PM, Sagi Grimberg wrote:
>
>>>> +    if (!nr->ctrl->error_logging)
>>>> +        req->rq_flags |= RQF_QUIET;
>>>> +
>>>> +    memcpy(nr->cmd, cmd, sizeof(*cmd));
>>>
>>> Question, if we already introduce granularity to this setting, why
>>> not per-ns? why only per controller? I'd think it makes more
>>> sense to do this per ns. Will also remove access to ctrl in the hot
>>> path...
>>
>>
>> Meaning we should have both:
>>
>> /sys/class/nvme/nvme0/passthrough_logging
>>
>> /sys/class/nvme/nvme0/nvme0n1/passthrough_logging
>
> No, just the namespace logging, why would we need the
> controller as well?

For Admin Commands?

Alan