Re: [RFC v3 1/1] nvme: add passthrough error logging opt-in

Sagi Grimberg
2023-04-03T22:38:41Z

>>> +    if (!nr->ctrl->error_logging)
>>> +        req->rq_flags |= RQF_QUIET;
>>> +
>>> +    memcpy(nr->cmd, cmd, sizeof(*cmd));
>>
>> Question, if we already introduce granularity to this setting, why
>> not per-ns? why only per controller? I'd think it makes more
>> sense to do this per ns. Will also remove access to ctrl in the hot
>> path...
>
>
> Meaning we should have both:
>
> /sys/class/nvme/nvme0/passthrough_logging
>
> /sys/class/nvme/nvme0/nvme0n1/passthrough_logging

No, just the namespace logging, why would we need the
controller as well?