Re: [RFC v3 1/1] nvme: add passthrough error logging opt-in

alan.adamson
2023-04-05T22:35:40Z

On 4/3/23 1:26 AM, Pankaj Raghav wrote:
> On Fri, Mar 31, 2023 at 03:18:23PM -0700, Alan Adamson wrote:
>> Commit d7ac8dca938c ("nvme: quiet user passthrough command errors") disabled error
>> logging for user passthrough commands. This commit adds the ability to opt-in
>> to passthrough error logging.
>>
>> To enable passthrough error logging:
>> echo 1 > /sys/class/nvme/nvme0/passthrough_logging
> passthrough_logging is a bit misleading as it doesn't indicate it is
> going to log only passthrough errors. `passthrough_error_logging` is a bit
> verbose but it is more apt for what this sysfs entry is doing. Maybe
> an abbreviation for passthrough_error_logging?

Since we are looking at only opting in to passthrough admin commands,
how about we call it:

/sys/class/nvme/nvme0/pt_admin_error_logging

Alan

>> To disable passthrough error logging:
>> echo 0 > /sys/class/nvme/nvme0/passthrough_logging
>>
>> By default, passthrough error logging will remain disabled.
>>