RE: [RFC v3 1/1] nvme: add passthrough error logging opt-in

Minwoo Im
2023-04-06T04:27:34Z

> -----Original Message-----
> From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
> Sent: Thursday, April 6, 2023 1:24 PM
> To: minwoo.im@samsung.com; alan.adamson@oracle.com; Pankaj Raghav Partha
> Sarathy <p.raghav@samsung.com>
> Cc: linux-nvme@lists.infradead.org; kbusch@kernel.org; hch@lst.de;
> sagi@grimberg.me
> Subject: Re: [RFC v3 1/1] nvme: add passthrough error logging opt-in
>
>
> >>> passthrough_logging is a bit misleading as it doesn't indicate it isa
> >>> going to log only passthrough errors. `passthrough_error_logging` is a bit
> >>> verbose but it is more apt for what this sysfs entry is doing. Maybe
> >>> an abbreviation for passthrough_error_logging?
> >> Since we are looking at only opting in to passthrough admin commands,
> >> how about we call it:
> >>
> >> /sys/class/nvme/nvme0/pt_admin_error_logging
> > I would make `passthrough` short to `passthu` as it looks like we don't use
> > `pt` as a short for passthrough in drivers/nvme/[host|target].
> >
>
> right it's "passthru" not "passthu", see :-

Yes, indeed. I missed out 'r' ;) Thanks for fixing this!

> /sys/kernel/config/nvmet/subsystems/tests
> ├── allowed_hosts
> ├── attr_allow_any_host
> ├── attr_cntlid_max
> ├── attr_cntlid_min
> ├── attr_firmware
> ├── attr_ieee_oui
> ├── attr_model
> ├── attr_pi_enable
> ├── attr_qid_max
> ├── attr_serial
> ├── attr_version
> ├── namespaces
> └── passthru
> ├── admin_timeout
> ├── clear_ids
> ├── device_path
> ├── enable
> └── io_timeout
>
>
> passthru_admin_err_logging should to the trick ...
> -ck