RE: [RFC v3 1/1] nvme: add passthrough error logging opt-in

Minwoo Im
2023-04-06T04:13:31Z

> -----Original Message-----
> From: Linux-nvme <linux-nvme-bounces@lists.infradead.org> On Behalf Of
> alan.adamson@oracle.com
> Sent: Thursday, April 6, 2023 7:35 AM
> To: Pankaj Raghav <p.raghav@samsung.com>
> Cc: linux-nvme@lists.infradead.org; kbusch@kernel.org; hch@lst.de;
> sagi@grimberg.me
> Subject: Re: [RFC v3 1/1] nvme: add passthrough error logging opt-in
>
>
> On 4/3/23 1:26 AM, Pankaj Raghav wrote:
> > On Fri, Mar 31, 2023 at 03:18:23PM -0700, Alan Adamson wrote:
> >> Commit d7ac8dca938c ("nvme: quiet user passthrough command errors") disabled
> error
> >> logging for user passthrough commands. This commit adds the ability to opt-in
> >> to passthrough error logging.
> >>
> >> To enable passthrough error logging:
> >> echo 1 > /sys/class/nvme/nvme0/passthrough_logging
> > passthrough_logging is a bit misleading as it doesn't indicate it is
> > going to log only passthrough errors. `passthrough_error_logging` is a bit
> > verbose but it is more apt for what this sysfs entry is doing. Maybe
> > an abbreviation for passthrough_error_logging?
>
> Since we are looking at only opting in to passthrough admin commands,
> how about we call it:
>
> /sys/class/nvme/nvme0/pt_admin_error_logging

I would make `passthrough` short to `passthu` as it looks like we don't use
`pt` as a short for passthrough in drivers/nvme/[host|target].