Re: [PATCH 1/2] io_uring: Pass whole sqe to commands

Breno Leitao
2023-04-30T14:38:08Z

On Thu, Apr 20, 2023 at 02:46:15PM +0200, Christoph Hellwig wrote:
> On Thu, Apr 20, 2023 at 05:38:02AM -0700, Breno Leitao wrote:
> > Since we are not coping the payload anymore, this is not necessary. Now
> > we are copying 64 bytes for the single SQE or 128 bytes for double SQE.
> >
> > Do you prefer I create a helper that returns the SQE size, instead of
> > doing the left shift?
>
> I think a helper would be nice. And adding another sizeof(sqe) seems
> more self documenting then the shift, but if you really prefer the
> shift at least write a good comment explaining it.

Agree, this is a good idea. I've fixed it in the nvme code by creating a
function helper.
The same problem happen on the ublkd_drv, and I've also fixed it there
in a new patch.

https://lkml.org/lkml/2023/4/30/94

Thanks for the review.