Re: [PATCH 1/2] io_uring: Pass whole sqe to commands

Christoph Hellwig
2023-04-20T12:46:24Z

On Thu, Apr 20, 2023 at 05:38:02AM -0700, Breno Leitao wrote:
> Since we are not coping the payload anymore, this is not necessary. Now
> we are copying 64 bytes for the single SQE or 128 bytes for double SQE.
>
> Do you prefer I create a helper that returns the SQE size, instead of
> doing the left shift?

I think a helper would be nice. And adding another sizeof(sqe) seems
more self documenting then the shift, but if you really prefer the
shift at least write a good comment explaining it.