From: Keith Busch <kbusch@kernel.org>
To: Max Gurtovoy <mgurtovoy@nvidia.com>
Cc: hch@lst.de, sagi@grimberg.me, linux-nvme@lists.infradead.org,
axboe@kernel.dk, oren@nvidia.com, israelr@nvidia.com
Subject: Re: [PATCH v2 1/1] nvme: move sysfs code to a dedicated sysfs.c file
Date: Mon, 15 May 2023 08:57:16 -0600 [thread overview]
Message-ID: <ZGJITKis7X6Eaot/@kbusch-mbp> (raw)
In-Reply-To: <20230424211242.19614-1-mgurtovoy@nvidia.com>
On Tue, Apr 25, 2023 at 12:12:42AM +0300, Max Gurtovoy wrote:
> The core.c file became long and hard to maintain. Create a dedicated
> file to centralize the sysfs functionality. This is a common practice to
> separate sysfs/configfs related logic from the main driver logic .c file.
> For example, in the nvmet module the configfs interface has its own
> dedicated file.
>
> This patch does not include any functional changes.
Thanks, I applied this for 6.5 with a couple minor changes:
I merged Chaitanya's dhchap memory leak fixes first, which touched some
of this sysfs code, so I simply used the the result when moving the code
to the new file.
I also added an 'include <linux/nvme-auth.h>' in the new sysfs.c file
for when CONFIG_NVME_AUTH=y.
next prev parent reply other threads:[~2023-05-15 14:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-24 21:12 [PATCH v2 1/1] nvme: move sysfs code to a dedicated sysfs.c file Max Gurtovoy
2023-04-25 15:27 ` Jens Axboe
2023-05-01 14:48 ` Max Gurtovoy
2023-04-26 11:27 ` Hannes Reinecke
2023-05-12 20:32 ` Christoph Hellwig
2023-05-15 14:57 ` Keith Busch [this message]
2023-05-15 17:02 ` Max Gurtovoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGJITKis7X6Eaot/@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=israelr@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=mgurtovoy@nvidia.com \
--cc=oren@nvidia.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox