From: Keith Busch <kbusch@kernel.org>
To: jiweisun126@126.com
Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
axboe@fb.com, hch@lst.de, sagi@grimberg.me, ahuang12@lenovo.com,
sunjw10@lenovo.com
Subject: Re: [PATCH] nvme: add cond_resched() to nvme_complete_batch()
Date: Mon, 15 May 2023 14:40:52 -0600 [thread overview]
Message-ID: <ZGKY1A1q5Px64v9h@kbusch-mbp> (raw)
In-Reply-To: <20230502125412.65633-1-jiweisun126@126.com>
On Tue, May 02, 2023 at 08:54:12PM +0800, jiweisun126@126.com wrote:
> From: Jiwei Sun <sunjw10@lenovo.com>
>
> A soft lockup issue will be triggered when do fio test on a 448-core
> server, such as the following warning:
...
> According to the above two logs, we can know the nvme_irq() cost too much
> time, in the above case, about 4.8 second. And we can also know that the
> main bottlenecks is in the competition for the spin lock pool->lock.
The most recent 6.4-rc has included a significant changeset to the pool
allocator that may show a considerable difference in pool->lock timing.
It would be interesting to hear if it changes your observation with your
448-core setup. Would you be able to re-run your experiements that
produced the soft lockup with this kernel on that machine?
next prev parent reply other threads:[~2023-05-15 20:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-02 12:54 [PATCH] nvme: add cond_resched() to nvme_complete_batch() jiweisun126
2023-05-03 16:07 ` Christoph Hellwig
2023-05-03 16:28 ` Keith Busch
2023-05-03 23:42 ` Keith Busch
2023-05-04 9:39 ` Niklas Cassel
2023-05-04 10:12 ` Niklas Cassel
2023-05-04 15:06 ` Keith Busch
2023-05-04 15:18 ` Niklas Cassel
2023-05-15 20:40 ` Keith Busch [this message]
2023-05-16 13:58 ` Jiwei Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGKY1A1q5Px64v9h@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=ahuang12@lenovo.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=jiweisun126@126.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=sunjw10@lenovo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox