* [PATCH] nvme-multipath: don't call blk_mark_disk_dead in nvme_mpath_remove_disk
@ 2023-05-17 7:53 Christoph Hellwig
2023-05-17 9:34 ` Sagi Grimberg
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Christoph Hellwig @ 2023-05-17 7:53 UTC (permalink / raw)
To: kbusch, sagi; +Cc: linux-nvme
nvme_mpath_remove_disk is called after del_gendisk, at which point a
blk_mark_disk_dead call doesn't make any sense.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
drivers/nvme/host/multipath.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/nvme/host/multipath.c b/drivers/nvme/host/multipath.c
index 9171452e2f6d4e..2bc159a318ff0a 100644
--- a/drivers/nvme/host/multipath.c
+++ b/drivers/nvme/host/multipath.c
@@ -884,7 +884,6 @@ void nvme_mpath_remove_disk(struct nvme_ns_head *head)
{
if (!head->disk)
return;
- blk_mark_disk_dead(head->disk);
/* make sure all pending bios are cleaned up */
kblockd_schedule_work(&head->requeue_work);
flush_work(&head->requeue_work);
--
2.39.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] nvme-multipath: don't call blk_mark_disk_dead in nvme_mpath_remove_disk
2023-05-17 7:53 [PATCH] nvme-multipath: don't call blk_mark_disk_dead in nvme_mpath_remove_disk Christoph Hellwig
@ 2023-05-17 9:34 ` Sagi Grimberg
2023-05-17 14:59 ` Keith Busch
2023-05-17 15:44 ` Keith Busch
2 siblings, 0 replies; 4+ messages in thread
From: Sagi Grimberg @ 2023-05-17 9:34 UTC (permalink / raw)
To: Christoph Hellwig, kbusch; +Cc: linux-nvme
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] nvme-multipath: don't call blk_mark_disk_dead in nvme_mpath_remove_disk
2023-05-17 7:53 [PATCH] nvme-multipath: don't call blk_mark_disk_dead in nvme_mpath_remove_disk Christoph Hellwig
2023-05-17 9:34 ` Sagi Grimberg
@ 2023-05-17 14:59 ` Keith Busch
2023-05-17 15:44 ` Keith Busch
2 siblings, 0 replies; 4+ messages in thread
From: Keith Busch @ 2023-05-17 14:59 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: sagi, linux-nvme
Thanks, applied to nvme-6.4.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] nvme-multipath: don't call blk_mark_disk_dead in nvme_mpath_remove_disk
2023-05-17 7:53 [PATCH] nvme-multipath: don't call blk_mark_disk_dead in nvme_mpath_remove_disk Christoph Hellwig
2023-05-17 9:34 ` Sagi Grimberg
2023-05-17 14:59 ` Keith Busch
@ 2023-05-17 15:44 ` Keith Busch
2 siblings, 0 replies; 4+ messages in thread
From: Keith Busch @ 2023-05-17 15:44 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: sagi, linux-nvme
Thanks, applied to nvme-6.4.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-05-17 15:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-17 7:53 [PATCH] nvme-multipath: don't call blk_mark_disk_dead in nvme_mpath_remove_disk Christoph Hellwig
2023-05-17 9:34 ` Sagi Grimberg
2023-05-17 14:59 ` Keith Busch
2023-05-17 15:44 ` Keith Busch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox