From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2910EC7EE29 for ; Thu, 8 Jun 2023 09:44:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7UW1P1+u4z8C1yYHhcCc7D6z205h5xRpA4Pis0U9UMY=; b=BqID+gqFxIw8x1E/mULpVHcjPm AuBtbtFlDraDm9P1lqOkJ4Pab6DijGg61eHCDlvzMqeHUbzQO4Vu4hxzLMGJQQ5J8su5kBIkS9gWu aEVZFZBb794YKbm+nxNkDZi46fUT3xF6gobB5qwf9en5IuWl1DJxyLtPbVKrbGRvh3xH5He+2Q8C8 P1yF2WsFccyrIrefKLjSLtHLtqv8JCVcAkw6NfMcm88Mmm71na15cE7UxagIUHCeV486abqxrZvpl 1qyyWH8u0emNFY7RtNNgaQ2/jFwU9IaQmYe+oP5kduqlZtEViGpjKXn1mRaYQuiHKh8XMxLX9afzB FuTFE29g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q7CBv-008jAs-1l; Thu, 08 Jun 2023 09:44:27 +0000 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q7CBs-008j9Y-2I for linux-nvme@lists.infradead.org; Thu, 08 Jun 2023 09:44:25 +0000 Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-30af56f5f52so280547f8f.1 for ; Thu, 08 Jun 2023 02:44:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=philpotter-co-uk.20221208.gappssmtp.com; s=20221208; t=1686217463; x=1688809463; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=7UW1P1+u4z8C1yYHhcCc7D6z205h5xRpA4Pis0U9UMY=; b=yaY1SeETpr1491wAArwoEz9AJZvZ5z5Oelfq8FTwZjv5Pt/tYo5/JbhJmlnsdXccgT rV+izm1qoxfwqsvCOevTNpa9AXiPp34leL/teWpFI8DnWj2gT9oTkJf5RM1JedYJsqOR dOTz2gvKJANj4eEOoND3rs/e3YQmKzzRMznHOfQHFfxuyaer9zt098pnWbKtUtWgrjpL rngkJTI/oyNl1h5w6WjYslic/vZHxQYsDYNvUly4Suef2mFO3KaGuI4pOX3o87LWbC1v fP5qRuJh7sd0u5OqO4m/B3exo8izpU2YK4CbQWdtPhbZm6I3/7vshaMygPH9B4aEMU3h 0vHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686217463; x=1688809463; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7UW1P1+u4z8C1yYHhcCc7D6z205h5xRpA4Pis0U9UMY=; b=SFehQxy3Qw2DShSNYjRDwUMmltkBONW6RiVFYD3xQLiwdNsZv1LbWTp8TR+2Q3j5u6 jkLJQcstrLT8YWwX2w+A12fRUZxC0JjiAjQPBGZwnNJ43whwUdJdl0dC1Wsqlrogwb+w hzOkLA8FS60DVE48l2HUndJr0evvi0yrxPgkKJC0UG6RfENT1jVJ26LfGxsWBWebNyzB KMnHEWc+7D2bhHR+AJ0KOHmyakyHj3kmyi3EAXTExTRKjQonW1tOTURrA9RSqsg6gcqV q9Bi4E+sMRgzM0ySgZMoIyC8StsdMWsmo73BXH5cc9QqxGlkyU2t/jMCKwfdX2vrRNRh 94+w== X-Gm-Message-State: AC+VfDw0AdzQ3Ow4+K/Fsq7NLnM0d2RbE6R/rm+zRGj12T2TH7tP3dVi Ochcuhryal6yJArr9QlEe/wdCA== X-Google-Smtp-Source: ACHHUZ55+QiuKZDDVF2xerotwpMLkKmO7qQkxSxt7AJ+yBOXmT5EW03OqeXuJJ7vWtahwa0aPclqwA== X-Received: by 2002:adf:e60c:0:b0:30a:e3da:efe5 with SMTP id p12-20020adfe60c000000b0030ae3daefe5mr6178509wrm.32.1686217463182; Thu, 08 Jun 2023 02:44:23 -0700 (PDT) Received: from equinox (2.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.a.1.e.e.d.f.d.0.b.8.0.1.0.0.2.ip6.arpa. [2001:8b0:dfde:e1a0::2]) by smtp.gmail.com with ESMTPSA id c17-20020adffb51000000b00307bc4e39e5sm1027878wrs.117.2023.06.08.02.44.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jun 2023 02:44:22 -0700 (PDT) Date: Thu, 8 Jun 2023 10:44:20 +0100 From: Phillip Potter To: Christoph Hellwig Cc: Jens Axboe , Richard Weinberger , Josef Bacik , "Md. Haris Iqbal" , Jack Wang , Coly Li , Miquel Raynal , Vignesh Raghavendra , "Martin K. Petersen" , Chris Mason , David Sterba , Alexander Viro , Christian Brauner , "Rafael J. Wysocki" , Pavel Machek , dm-devel@redhat.com, linux-block@vger.kernel.org, linux-um@lists.infradead.org, linux-scsi@vger.kernel.org, linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, linux-btrfs@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-nilfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 06/31] cdrom: remove the unused mode argument to cdrom_release Message-ID: References: <20230606073950.225178-1-hch@lst.de> <20230606073950.225178-7-hch@lst.de> <20230608084129.GA14689@lst.de> <20230608090444.GA15075@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230608090444.GA15075@lst.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230608_024424_751985_FC4E5265 X-CRM114-Status: GOOD ( 19.21 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Thu, Jun 08, 2023 at 11:04:44AM +0200, Christoph Hellwig wrote: > On Thu, Jun 08, 2023 at 09:47:27AM +0100, Phillip Potter wrote: > > Yes indeed - I was under the impression it was appropriate for a > > maintainer to signal their approval of a patch to maintained code using > > a Signed-off-by tag due to their involvement in the submission process? > > Apologies if I've got this wrong, happy to send Reviewed-bys by all > > means. > > Signed-off-by is for the chain that the patches pass through. You add > it when you apply or forward the patch. Just give me a Reviewed-by > tag and say it shold apply to patches 1 to 6 and I'll add it. Thanks for the guidance. Please apply the following to the block patch (1) and the CD-ROM patches (2-6) of your series, all looks good to me: Reviewed-by: Phillip Potter Regards, Phil