From: Keith Busch <kbusch@kernel.org>
To: Irvin Cote <irvincoteg@gmail.com>
Cc: hch@lst.de, axboe@kernel.dk, sagi@grimberg.me,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme-core: check id->mc before setting NVME_NS_METADATA_SUPPORTED
Date: Tue, 27 Jun 2023 09:30:44 -0600 [thread overview]
Message-ID: <ZJsApH5rwOcsmFB0@kbusch-mbp.dhcp.thefacebook.com> (raw)
In-Reply-To: <20230624103502.8772-1-irvincoteg@gmail.com>
On Sat, Jun 24, 2023 at 12:35:02PM +0200, Irvin Cote wrote:
> The NVM Command set Identify Namespace Data Structure defines
> the metadata capabilities field (mc) that determines support for
> metadata. Check for the value of this field before enabling the
> NVME_NS_METADATA_SUPPORTED in the nvme_ns data structure.
The MC field is primarily for use when sending a format command to know
what are valid possibilities. If the reported MS and FLBAS are out of
sync with metadata capabilities, then the controller is broken.
next prev parent reply other threads:[~2023-06-27 15:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-24 10:35 [PATCH] nvme-core: check id->mc before setting NVME_NS_METADATA_SUPPORTED Irvin Cote
2023-06-27 15:30 ` Keith Busch [this message]
2023-06-27 16:02 ` Max Gurtovoy
2023-06-30 17:41 ` irvin cote
2023-07-02 14:02 ` irvin cote
2023-07-10 7:01 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJsApH5rwOcsmFB0@kbusch-mbp.dhcp.thefacebook.com \
--to=kbusch@kernel.org \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=irvincoteg@gmail.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox