From: Christoph Hellwig <hch@infradead.org>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>,
linux-nvme@lists.infradead.org, Keith Busch <kbusch@kernel.org>,
Johannes Thumshirn <johannes.thumshirn@wdc.com>
Subject: Re: [PATCH] nvme: zns: limit max_zone_append by max_segments
Date: Mon, 31 Jul 2023 07:05:40 -0700 [thread overview]
Message-ID: <ZMe/tFLYy8xR9EWs@infradead.org> (raw)
In-Reply-To: <2dea2a1c-b127-4661-c232-4dcf0b249878@kernel.org>
On Mon, Jul 31, 2023 at 11:02:35PM +0900, Damien Le Moal wrote:
> >
> > blk_queue_max_zone_append_sectors(q,
> > queue_max_sectors(q), ns->ctrl->max_zone_append);
>
> blk_queue_max_zone_append_sectors() already does cap max zone append to
> max_hw_sectors.
Then we should not need this..
> We could also add the cap to queue_max_segments(q) <<
> PAGE_SECTORS_SHIFT in that function as well given that all zoned devices should
> have that anyway...
No. That's a NVMe specific thing. Most SCSI HBAs don't have this
issue. NVMe devices supporting SGLs don't really have it either, but
for that we'd need to commit to always using SGLs for non-tiny I/O,
which we should probably be doing.
next prev parent reply other threads:[~2023-07-31 14:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 11:46 [PATCH] nvme: zns: limit max_zone_append by max_segments Shin'ichiro Kawasaki
2023-07-31 12:03 ` Damien Le Moal
2023-07-31 13:51 ` Christoph Hellwig
2023-07-31 14:01 ` Damien Le Moal
2023-07-31 14:06 ` Christoph Hellwig
2023-07-31 14:12 ` Damien Le Moal
2023-07-31 14:26 ` Christoph Hellwig
2023-07-31 14:33 ` Damien Le Moal
2023-07-31 13:46 ` Christoph Hellwig
2023-07-31 14:02 ` Damien Le Moal
2023-07-31 14:05 ` Christoph Hellwig [this message]
2023-07-31 14:07 ` Damien Le Moal
2023-07-31 14:08 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMe/tFLYy8xR9EWs@infradead.org \
--to=hch@infradead.org \
--cc=dlemoal@kernel.org \
--cc=johannes.thumshirn@wdc.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox