public inbox for linux-nvme@lists.infradead.org
 help / color / mirror / Atom feed
From: Keith Busch <kbusch@kernel.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Christoph Hellwig <hch@lst.de>,
	linux-nvme@lists.infradead.org, kernel-janitors@vger.kernel.org,
	Mark O'Donovan <shiftee@posteo.net>,
	Hannes Reinecke <hare@suse.de>, Jens Axboe <axboe@kernel.dk>,
	Sagi Grimberg <sagi@grimberg.me>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [1/2] nvme-auth: unlock mutex in one place only
Date: Mon, 31 Jul 2023 12:18:45 -0600	[thread overview]
Message-ID: <ZMf7BUH3ZD+GA7TA@kbusch-mbp> (raw)
In-Reply-To: <d51771bc-32a6-7424-ba02-bcc8ab9bf3f8@web.de>

On Mon, Jul 31, 2023 at 07:46:25PM +0200, Markus Elfring wrote:
> >> Are imperative change descriptions still preferred?
> >
> > It doesn't fucking matter.
> 
> Do you exaggerate here?
> 
> If not:
> Does such a feedback really indicate that you would intentionally like to
> disagree with specific requirements from the Linux development documentation
> (for a discussed patch)?

The subject is already in the imperative voice, and there's really
nothing furthur to elaborate that would help justify this patch's
inclusion. I'm not sure what point you're trying to make here.


  reply	other threads:[~2023-07-31 18:18 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-27 13:47 [PATCH 1/2] nvme-auth: unlock mutex in one place only Mark O'Donovan
2023-07-27 13:47 ` [PATCH 2/2] nvme-auth: set explanation code for failure2 msgs Mark O'Donovan
2023-07-31  5:58   ` Christoph Hellwig
2023-07-31 16:17     ` Hannes Reinecke
2023-07-31  5:55 ` [PATCH 1/2] nvme-auth: unlock mutex in one place only Christoph Hellwig
2023-07-31 12:00 ` Markus Elfring
2023-07-31 13:51   ` Christoph Hellwig
2023-07-31 17:46     ` [1/2] " Markus Elfring
2023-07-31 18:18       ` Keith Busch [this message]
2023-07-31 18:37         ` Markus Elfring
2023-07-31 18:43           ` Keith Busch
2023-07-31 13:51 ` [PATCH 1/2] " Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZMf7BUH3ZD+GA7TA@kbusch-mbp \
    --to=kbusch@kernel.org \
    --cc=Markus.Elfring@web.de \
    --cc=axboe@kernel.dk \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    --cc=shiftee@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox