From: Keith Busch <kbusch@kernel.org>
To: Hannes Reinecke <hare@suse.de>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH 0/4] nvme: start keep-alive after admin queue setup
Date: Mon, 23 Oct 2023 17:16:37 -0600 [thread overview]
Message-ID: <ZTb-1XJyQfLrSC1a@kbusch-mbp> (raw)
In-Reply-To: <94326b59-60c1-4d0b-863b-cec0f9bfe1ac@suse.de>
On Mon, Oct 23, 2023 at 11:54:37AM +0200, Hannes Reinecke wrote:
> But we start keep alive unconditionally nowadays; each and every
> host driver (including PCI) is calling into nvme_start_ctrl(),
> which calls nvme_start_keep_alive() without any checks.
I see nvme_start_keep_alive() is always called, but that checks
'ctrl->kato' which will always be 0 for PCI.
> Be it as it may, tying it into the state transition won't work
> as the 'CONNECTING' state is entered _before_ any queues are setup,
> so starting keep-alive here would be too early.
That's just IO eueues, right? Keep-alive is an admin command, and the
admin queue should be up in the CONNECTING state.
next prev parent reply other threads:[~2023-10-23 23:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 14:25 [PATCH 0/4] nvme: start keep-alive after admin queue setup Hannes Reinecke
2023-10-20 14:25 ` [PATCH 1/4] nvme-fc: add missing quiesce in nvme_fc_create_association() Hannes Reinecke
2023-10-20 14:25 ` [PATCH 2/4] nvme-pci: unquiesce admin queue before nvme_init_ctrl_finish() Hannes Reinecke
2023-10-20 14:25 ` [PATCH 3/4] nvme-loop: quiesce admin queue on failure Hannes Reinecke
2023-10-20 14:26 ` [PATCH 4/4] nvme: start keep-alive after admin queue setup Hannes Reinecke
2023-10-20 15:30 ` [PATCH 0/4] " Keith Busch
2023-10-23 9:54 ` Hannes Reinecke
2023-10-23 23:16 ` Keith Busch [this message]
2023-10-24 5:30 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZTb-1XJyQfLrSC1a@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox