From: Keith Busch <kbusch@kernel.org>
To: Maurizio Lombardi <mlombard@redhat.com>
Cc: sagi@grimberg.me, zahavi.alon@gmail.com, hch@lst.de,
chaitanyak@nvidia.com, linux-nvme@lists.infradead.org
Subject: Re: [PATCH 1/2] nvmet-tcp: Fix a kernel panic when host sends an invalid H2C PDU length
Date: Thu, 21 Dec 2023 10:42:22 -0700 [thread overview]
Message-ID: <ZYR4_ifqRtrwgwVt@kbusch-mbp> (raw)
In-Reply-To: <20231221163154.605669-2-mlombard@redhat.com>
On Thu, Dec 21, 2023 at 05:31:53PM +0100, Maurizio Lombardi wrote:
> @@ -1002,6 +1003,13 @@ static int nvmet_tcp_handle_h2c_data_pdu(struct nvmet_tcp_queue *queue)
> }
>
> cmd->pdu_len = le32_to_cpu(data->data_length);
> + if (unlikely(cmd->pdu_len == 0 ||
> + cmd->pdu_len > NVMET_TCP_MAXH2CDATA)) {
> + pr_err("H2CData PDU len out of range\n");
Please add the 'pdu_len' to the pr_err since that info sounds useful to
knowing which type of target error we're dealing with.
Otherwise looks good!
Reviewed-by: Keith Busch <kbusch@kernel.org>
> + /* FIXME: use proper transport errors */
> + nvmet_tcp_fatal_error(queue);
> + return -EPROTO;
> + }
> cmd->pdu_recv = 0;
> nvmet_tcp_build_pdu_iovec(cmd);
> queue->cmd = cmd;
next prev parent reply other threads:[~2023-12-21 17:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-21 16:31 [PATCH 0/2] Fix some kernel panics due to the host sending invalid PDUs Maurizio Lombardi
2023-12-21 16:31 ` [PATCH 1/2] nvmet-tcp: Fix a kernel panic when host sends an invalid H2C PDU length Maurizio Lombardi
2023-12-21 17:42 ` Keith Busch [this message]
2023-12-22 8:41 ` Maurizio Lombardi
2023-12-21 16:31 ` [PATCH 2/2] nvmet-tcp: fix a crash in nvmet_req_complete() Maurizio Lombardi
2023-12-21 21:19 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZYR4_ifqRtrwgwVt@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=chaitanyak@nvidia.com \
--cc=hch@lst.de \
--cc=linux-nvme@lists.infradead.org \
--cc=mlombard@redhat.com \
--cc=sagi@grimberg.me \
--cc=zahavi.alon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox