From: Keith Busch <kbusch@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: sagi@grimberg.me, linux-nvme@lists.infradead.org,
Nilay Shroff <nilay@linux.ibm.com>
Subject: Re: [PATCH] nvme-multipath: don't inherit LBA-related fields for the multipath node
Date: Fri, 22 Mar 2024 10:22:30 -0600 [thread overview]
Message-ID: <Zf2wRtNqNU2qTpHE@kbusch-mbp> (raw)
In-Reply-To: <20240321210819.1246749-1-hch@lst.de>
On Fri, Mar 22, 2024 at 07:08:19AM +1000, Christoph Hellwig wrote:
> Linux 6.9 made the nvme multipath nodes not properly pick up changes when
> the LBA size goes smaller after an nvme format. This is because we now
> try to inherit the queue settings for the multipath node entirely from
> the individual paths. That is the right thing to do for I/O size
> limitations, which make up most of the queue limits, but it is wrong for
> changes to the namespace configuration, where we do want to pick up the
> new format, which will eventually show up on all paths once they are
> re-queried.
>
> Fix this by not inheriting the block size and related fields and always
> for updating them.
>
> Fixes: 8f03cfa117e0 ("nvme: don't use nvme_update_disk_info for the multipath disk")
Applied to nvme-6.9. This just missed yesterday's pull, but at least
it's queued up for the next one.
next prev parent reply other threads:[~2024-03-22 16:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-21 21:08 [PATCH] nvme-multipath: don't inherit LBA-related fields for the multipath node Christoph Hellwig
2024-03-22 5:15 ` Nilay Shroff
2024-03-22 16:22 ` Keith Busch [this message]
2024-04-02 13:21 ` Nilay Shroff
2024-04-02 14:15 ` Keith Busch
2024-03-23 20:33 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zf2wRtNqNU2qTpHE@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=hch@lst.de \
--cc=linux-nvme@lists.infradead.org \
--cc=nilay@linux.ibm.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox